Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TryStream to Stream #1102

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Feb 18, 2023

While Stream<Item = Result<T, E>> implements TryStream<Ok = T, Error = E>,
https://docs.rs/futures/latest/futures/prelude/trait.TryStream.html#impl-TryStream-for-S

TryStream<Ok = T, Error = E> does not implement Stream<Item = Result<T, E>>.
That's why we were sometimes writing TryStream<Ok=T, Error = E, Item = Result<T, E>>.
Replace this with.

@ever0de ever0de added the improvement Improvements for existing features label Feb 18, 2023
@ever0de ever0de self-assigned this Feb 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4210958655

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.796%

Totals Coverage Status
Change from base Build 4210253137: 0.0%
Covered Lines: 39723
Relevant Lines: 40207

💛 - Coveralls

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also nice improvement! Thanks a lot 👍

@panarch panarch merged commit 6529250 into gluesql:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants