Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Box::pin to futures_enum::Stream #1103

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Replace Box::pin to futures_enum::Stream #1103

merged 1 commit into from
Feb 18, 2023

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Feb 18, 2023 •
edited

depend on: #1102

@ever0de ever0de added the improvement Improvements for existing features label Feb 18, 2023
@ever0de ever0de self-assigned this Feb 18, 2023
@coveralls
Copy link

coveralls commented Feb 18, 2023 •
edited

Pull Request Test Coverage Report for Build 4211048642

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0001%) to 98.796%
Totals Coverage Status
Change from base Build 4211047011: -0.0001%
Covered Lines: 39719
Relevant Lines: 40203
💛 - Coveralls

@ever0de ever0de force-pushed the replace-box-pin-to-futures_enum branch from 0e9b26b to 61c7ae9 Compare February 18, 2023 11:59
panarch
panarch approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the nice one! Thanks a lot 👍 👍

@panarch panarch merged commit 90864a4 into gluesql:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@ever0de ever0de

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ever0de @coveralls @panarch