Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #186: Fix i18n feature #189

Merged
merged 2 commits into from Jun 13, 2018
Merged

Issue #186: Fix i18n feature #189

merged 2 commits into from Jun 13, 2018

Conversation

tawAsh1
Copy link
Contributor

@tawAsh1 tawAsh1 commented Jun 13, 2018

Fixes #186

Implements custom control
When reading unicode escaped strings, custom control might be needed.
https://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-resource-properties-with-resourcebundle

@tiainen
Copy link
Contributor

tiainen commented Jun 13, 2018

That looks very good, thank you!

A final note, could you also please sign the Gluon CLA at http://cla.gluonhq.com?

@tawAsh1
Copy link
Contributor Author

tawAsh1 commented Jun 13, 2018

Thank you very much for your cooperation!
It was my first PR and I am very happy that PR was approved.
Yes, I signed it.

@tiainen tiainen merged commit c25685b into gluonhq:master Jun 13, 2018
@tiainen
Copy link
Contributor

tiainen commented Jun 13, 2018

And thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants