Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JRuby controller skeleton generation #596

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

byteit101
Copy link
Contributor

@byteit101 byteit101 commented Oct 26, 2022

Adds JRuby as a language to the controller skeleton dialog. Note that JRuby doesn't need the fields, as JRubyFX inserts all of them automatically, this is principally for the methods/callbacks, and field reference.

Based on discussion #595

Progress

@byteit101 byteit101 marked this pull request as ready for review November 10, 2022 00:59
@Oliver-Loeffler
Copy link
Collaborator

There exists a naming convention for PRs requiring prefix to make clear what their purpose is.
https://github.com/gluonhq/scenebuilder/blob/master/CONTRIBUTING.md#pull-request-standards
In this case I would consider: "feat: add functionality to generate JRuby controller skeleton" as a suitable name.

@byteit101 byteit101 changed the title Add JRuby controller skeleton Feat: Add JRuby controller skeleton generation Nov 15, 2022
@abhinayagarwal abhinayagarwal changed the title Feat: Add JRuby controller skeleton generation feat: Add JRuby controller skeleton generation Mar 24, 2023
@abhinayagarwal
Copy link
Collaborator

@Oliver-Loeffler Can you review this PR again? Author has addressed your comments.

Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License headers look okay now. Also I've tested this PR and it works fine. Also new languages can be added by just implementing the SkeletonConverter.

@abhinayagarwal abhinayagarwal requested review from abhinayagarwal and removed request for Oliver-Loeffler March 24, 2023 19:54
@abhinayagarwal abhinayagarwal merged commit 5ce9f65 into gluonhq:master Mar 24, 2023
Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just closed the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants