-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add JRuby controller skeleton generation #596
Conversation
There exists a naming convention for PRs requiring prefix to make clear what their purpose is. |
kit/src/main/java/com/oracle/javafx/scenebuilder/kit/skeleton/AbstractSkeletonCreator.java
Show resolved
Hide resolved
@Oliver-Loeffler Can you review this PR again? Author has addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License headers look okay now. Also I've tested this PR and it works fine. Also new languages can be added by just implementing the SkeletonConverter
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just closed the review.
Adds JRuby as a language to the controller skeleton dialog. Note that JRuby doesn't need the fields, as JRubyFX inserts all of them automatically, this is principally for the methods/callbacks, and field reference.
Based on discussion #595
Progress