Some runtime enhacements #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelbabu
suggested changes
Oct 17, 2016
There was a problem hiding this comment.
Thank you for looking into this!
There's a few changes I'd like to see done before we merge this:
- Using
shell=Trueis definitely not the recommended approach. If something is failing, let's fix it so it runs withoutshell=True. - You've accidentally given execute bits to README.md.
| @@ -183,7 +183,7 @@ def make_report(size, average_seq_write, average_seq_read, average_rand_write, a | |||
| print "Smallfile ls -l " + str(size) + " file size: " + str(average_smallfile_ls) | |||
|
|
|||
| def run_command(command_in): | |||
| p = subprocess.Popen(command_in, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) | |||
| p = subprocess.Popen(command_in, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True) | |||
There was a problem hiding this comment.
I think we should edit these to be proper dictionaries rather than passing shell=True.
|
Closing the PR as there is no activity in close to 2 years. Further the bench py script is set to undergo changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
inputtoraw_input: Makes easier for user to input option.shell=True, due to runtime error of missing subprocess.py.