Removing to_json because before ansible v2.13 its returning dictionar… #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y and from its returning as string. Actually the orignal behaviour of this function is to return string but in ansible 2.12 was a mistake i guess. Now in ansible 2.13 the original behaviour is back so we don't need to use to_json Refer Doc: ansible/ansible#76443 (comment) Bug:- gluster#135
|
Tested successfully with ansible 2.14.1 and python 3.9.16 on CentOS Stream 8! Thx! |
anoopcs9
reviewed
Jan 22, 2023
|
@gobindadas do you know if there's anyone looking at the PRs of this repo from time to time ? Is it ok if I take a look and merge some patches myself ? |
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Oct 13, 2023
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Oct 13, 2023
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. In addition to that we split the installation of python jmespath module to be more correct depending on the distro version. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Oct 13, 2023
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. In addition to that we split the installation of python jmespath module to be more correct depending on the distro version. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to samba-in-kubernetes/sit-environment
that referenced
this pull request
Oct 13, 2023
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. In addition to that we split the installation of python jmespath module to be more correct depending on the distro version. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, the original behavior of this function is to return a string but in ansible 2.12 was a mistake I guess. Now in ansible 2.13, the original behavior is back so we don't need to use to_json
Refer Doc: ansible/ansible#76443 (comment)
Bug:- #135