-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing to_json because before ansible v2.13 its returning dictionar… #136
Conversation
…y and from its returning as string. Actually the orignal behaviour of this function is to return string but in ansible 2.12 was a mistake i guess. Now in ansible 2.13 the original behaviour is back so we don't need to use to_json Refer Doc: ansible/ansible#76443 (comment) Bug:- gluster#135
Tested successfully with ansible 2.14.1 and python 3.9.16 on CentOS Stream 8! Thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks and sorry for the very late response.
@gobindadas do you know if there's anyone looking at the PRs of this repo from time to time ? Is it ok if I take a look and merge some patches myself ? |
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. In addition to that we split the installation of python jmespath module to be more correct depending on the distro version. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. In addition to that we split the installation of python jmespath module to be more correct depending on the distro version. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Now that the required fixes[1] are in for gluster-ansible we could use latest ansible packages. In addition to that we split the installation of python jmespath module to be more correct depending on the distro version. [1] gluster/gluster-ansible-infra#136 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Actually, the original behavior of this function is to return a string but in ansible 2.12 was a mistake I guess. Now in ansible 2.13, the original behavior is back so we don't need to use to_json
Refer Doc: ansible/ansible#76443 (comment)
Bug:- #135