Add role to reset backend bricks #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sac
commented
Sep 25, 2018
sac
commented
- Remove the outdated examples directory
- Add playbooks to remove the bricks
* Remove the outdated examples directory * Add playbooks to remove the bricks
sabose
reviewed
Oct 3, 2018
tasks/main.yml
Outdated
| @@ -14,3 +14,13 @@ | |||
| name: "gluster.infra/roles/backend_setup" | |||
| tags: | |||
| - backend_setup | |||
|
|
|||
| - name: Rest backend | |||
playbooks/brick_reset.yml
Outdated
| gather_facts: no | ||
| hosts: all | ||
| vars: | ||
| gluster_infra_reset_mnt_paths: |
There was a problem hiding this comment.
can the vars be separated out to a separate file? In that case, we do not need to provide multiple playbooks - brick_reset.yml, brick_reset_vdo.yml etc ?
|
@sabose updated commit. Request for review. |
sabose
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.