RFE: Replace host for same fqdn #108

gobindadas · 2020-05-14T07:15:19Z

RHBZ: 1832658

satheesaran · 2020-05-23T13:05:30Z

playbooks/hc-ansible-deployment/node_replace_inventory.yml

@@ -0,0 +1,10 @@
+cluster_node:
+  hosts:
+   # mention whatever host is provided in gluster_maintenance_cluster_node or in gluster_maintenance_cluster_node_2 either one.


Improve the comment section. What should be the hostname that should here should be clear. There shouldn't be ambiguity. Something like : "this is the backend network FQDN of one of the active hosts. It can take a value of the hosts in gluster_maintenance_cluster_node

This can be better named as

satheesaran · 2020-05-23T13:09:42Z

playbooks/hc-ansible-deployment/node_replace_inventory.yml

+    gluster_maintenance_old_node: <host1-backend-network-FQDN>
+    gluster_maintenance_new_node: <host1-backend-network-FQDN>
+    gluster_maintenance_cluster_node: <host2-backend-network-FQDN>
+    gluster_maintenance_cluster_node_2: <host3-backend-network-FQDN>


Better names should be good:
gluster_maintenance_old_node:
gluster_maintenance_new_node:
gluster_maintenance_cluster_node:
gluster_maintenance_cluster_node_2:

satheesaran

I have few comments to improve the comments in the inventory files to replace the host

satheesaran · 2020-05-23T13:11:14Z

@gobindadas Please add clean and easily understandable comments in the node_replace_inventory.yml file.

pkesavap · 2020-05-14T11:38:44Z

playbooks/hc-ansible-deployment/node_replace_inventory.yml

@@ -0,0 +1,10 @@
+cluster_node:
+  hosts:


just adding a comment for cli users:-

make sure whatever host you are providing here is where the playbook should be executed.

pkesavap · 2020-05-22T07:09:30Z

playbooks/hc-ansible-deployment/node_prep_inventory.yml

+          lvsize: 200G
+
+  # Common configurations
+  vars:


this part needs to be properly intended, since hc nodes in the top is being implemented as a class type and we are only parsing a single class, and this is not properly intended, its taking 'vars' as another hostname

This is properly intended. I don't think "vars" will take as hosts.

PLAY RECAP ***********************************************************************************************************************************************************************
nixcraft-praji1-rhel8.com : ok=9 changed=3 unreachable=0 failed=1 skipped=15 rescued=0 ignored=0
vars : ok=0 changed=0 unreachable=1 failed=0 skipped=0 rescued=0 ignored=0

pkesavap

Vars needs to be intended

pkesavap · 2020-05-26T06:36:38Z

playbooks/hc-ansible-deployment/node_prep_inventory.yml

+          lvsize: 200G
+
+  # Common configurations
+  vars:


PLAY RECAP ***********************************************************************************************************************************************************************
nixcraft-praji1-rhel8.com : ok=9 changed=3 unreachable=0 failed=1 skipped=15 rescued=0 ignored=0
vars : ok=0 changed=0 unreachable=1 failed=0 skipped=0 rescued=0 ignored=0

pkesavap · 2020-05-26T06:41:09Z

also just wanted to know, wouldn't it be better to include two inventory in the same file,
because node_replace_inventory.yml should be executed in the gluster_maintancence host, but the node_prep could does not have any such restriction,
since the node_prep is there for replace host flow, wouldnt it be better to have a good single inventory file for replace host, rather than multiple?

satheesaran · 2020-05-26T07:29:49Z

playbooks/hc-ansible-deployment/node_replace_inventory.yml

+    gluster_maintenance_old_node: <gluster_maintenance_old_node>
+    gluster_maintenance_new_node: <gluster_maintenance_new_node>
+    gluster_maintenance_cluster_node: <gluster_maintenance_cluster_node>
+    gluster_maintenance_cluster_node_2: <gluster_maintenance_cluster_node_2>


Still I feel we need to emphasize on backend network in the name. Something like previous sounds good. 'host-backend-network-FQDN'. That will add more clarity whether to add front-end or back-end.

satheesaran

I still feel the need for adding hostname along with backend-network-FQDN, and that would clarify the ambiguity

satheesaran · 2020-05-26T07:37:56Z

playbooks/hc-ansible-deployment/tasks/replace_node.yml

+    - block:
+      - name: Gluster host preparation
+        include_role:
+         name: "{{ item }}"


When I executed the playbook, I got this warning - "The loop variable 'item' is already in use." for each task execution. I have replaced it with separate loop_variable and that solved the problem. Please incorporate the same

satheesaran

While executing the replace_host playbook, I was seeing this warning "The loop variable 'item' is already in use." for every task execution, I have supplemented 'with_items' with loop_control and loop_variable and that solved the problem

satheesaran · 2020-05-26T07:41:59Z

@gobindadas While executing the replace_host playbook, I was seeing this warning "The loop variable 'item' is already in use." for every task execution, I have supplemented 'with_items' with loop_control and loop_variable and that solved the problem

hosts: hc_nodes
remote_user: root
gather_facts: yes
tasks:
- block:
  - name: Gluster host preparation
    include_role:
    name: "{{ line_item }}"
    with_items:
    - gluster.infra
    - gluster.features
      loop_control:
      loop_var: line_item
      tags:
  - preparehost

pkesavap · 2020-05-26T10:00:26Z

Vars needs to be intended

Apologies, It is properly intended, issue was with my setup

gobindadas · 2020-05-26T10:42:12Z

Fixed all comments

satheesaran

Looks good to me

RFE: Replace host for same fqdn

8d7836b

satheesaran reviewed May 23, 2020

View reviewed changes

pkesavap reviewed May 24, 2020

View reviewed changes

Added proper comments and node name

f56466f

pkesavap requested changes May 26, 2020

View reviewed changes

satheesaran reviewed May 26, 2020

View reviewed changes

Fixed warning issue

fb06a66

pkesavap approved these changes May 26, 2020

View reviewed changes

Added proper name for hosts

1ee593d

satheesaran approved these changes May 26, 2020

View reviewed changes

gobindadas merged commit 4be5edd into gluster:master May 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RFE: Replace host for same fqdn #108

RFE: Replace host for same fqdn #108

gobindadas commented May 14, 2020

satheesaran May 23, 2020

satheesaran May 23, 2020

satheesaran left a comment

satheesaran commented May 23, 2020

pkesavap May 14, 2020

pkesavap May 22, 2020

gobindadas May 25, 2020

pkesavap May 26, 2020

pkesavap left a comment

pkesavap May 26, 2020

pkesavap commented May 26, 2020

satheesaran May 26, 2020

satheesaran left a comment

satheesaran May 26, 2020

satheesaran left a comment

satheesaran commented May 26, 2020

pkesavap commented May 26, 2020

gobindadas commented May 26, 2020

satheesaran left a comment

RFE: Replace host for same fqdn #108

RFE: Replace host for same fqdn #108

Conversation

gobindadas commented May 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satheesaran left a comment

Choose a reason for hiding this comment

satheesaran commented May 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkesavap left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkesavap commented May 26, 2020

Choose a reason for hiding this comment

satheesaran left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satheesaran left a comment

Choose a reason for hiding this comment

satheesaran commented May 26, 2020

pkesavap commented May 26, 2020

gobindadas commented May 26, 2020

satheesaran left a comment

Choose a reason for hiding this comment