New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate ovirt gluster network post hc deployment #109
Conversation
- name: "{{ cluster_name }}" | ||
assigned: true | ||
required: false | ||
gluster: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This network is also a migration network, please add migration: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to ignore this patch as we decided to create a separate playbook for gluster_network creation, as the hosts are added to the cluster in the async fashion, creation of network had to wait for long time which also prolongs the deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this network also a migration role supported
@gobindadas This part of the code creates the gluster logical network, but this doesn't attach that network to the hosts. ovirt_host_network ansible module helps in attaching the network to the required host network interface. Now you need to get that interface as input from the user for each host. so it should be part of gluster_inventory.yml Please make that change too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to ignore this patch as we decided to create a separate playbook for gluster_network creation, as the hosts are added to the cluster in the async fashion, creation of network had to wait for long time which also prolongs the deployment
Verified, it's working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good to me
RHBZ: 1835574