This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
gk-deploy: fix heketi.json for heketi-HA #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
|
why is this a pr of its own and also part of pr #289 ? |
|
....not really sure. I think I was just tired this morning when I found the bug. ;) |
|
so this is a fix of something introduced earlier, not of something introduced in the idempotency pr, right? |
|
Oh, yes, it was introduced in #281 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a key configuration parameter.
Signed-off-by: Jose A. Rivera jarrpa@redhat.com
This change is