This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Snapshot auto mount bricks on glusterd restart #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishubhjain
reviewed
Jul 23, 2018
glusterd2/volume/fs_utils.go
Outdated
| } | ||
|
|
||
| if err := unix.Setxattr(brickinfo.Path, volumeIDXattrKey, vol.ID, 0); err != nil { | ||
| log.WithFields(log.Fields{"error": err.Error(), |
There was a problem hiding this comment.
Its better to log error using WithError. log.WithError(err).WithFields...
Madhu-1
reviewed
Jul 23, 2018
| return errors.New("volume size should provide to perform auto create") | ||
| } | ||
|
|
||
| if !req.SelfProvision && len(req.Subvols) <= 0 { |
There was a problem hiding this comment.
question:
what happens if I request for SelfProvision= true and req.Subvols length greater than zero
There was a problem hiding this comment.
Since you requested for smartvol, given bricks should omit or we should have the capability of having both. But I will let @aravindavk answer the question as it is not specific to this PR.
rafikc30
force-pushed
the
snapshot_auto_mount
branch
from
5980ac8
to
d6f5e8d
Compare
ghost
assigned
rafikc30
force-pushed
the
snapshot_auto_mount
branch
2 times, most recently
from
25def30
to
64ac57a
Compare
aravindavk
approved these changes
Oct 9, 2018
Madhu-1
reviewed
Oct 9, 2018
Madhu-1
reviewed
Oct 9, 2018
prashanthpai
reviewed
Oct 9, 2018
rafikc30
force-pushed
the
snapshot_auto_mount
branch
from
96e6ba5
to
39caf2b
Compare
Snapshot bricks are provisoned by glusterd. During a glusterd restart, we should check for brick mounts for activated snapshots. Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
During a snapshot restore, we need to delete the parent lv's if it is auto provisioned or snapshot provisioned Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
rafikc30
force-pushed
the
snapshot_auto_mount
branch
from
39caf2b
to
626ea49
Compare
|
I see the review comments are addressed. I will merge this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot bricks should automatically mount upon a glusterd restart. Especially after glusterd restart, mount won't be existing on the machine. This PR will mount the snapshot bricks during a glusterd restart.