This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Include gluster-prometheus-exporter rpm in glusterd2 container #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Oct 31, 2018
|
retest this please |
|
Nightly rpm is now setup http://artifacts.ci.centos.org/gluster/gluster-prometheus-nightly/ (centosci PR: gluster/centosci#36) Removed |
JohnStrunk
reviewed
Nov 6, 2018
| - name: Configure gluster-exporter to use glusterd2 | ||
| replace: | ||
| path: /etc/gluster-exporter/gluster-exporter.toml | ||
| regexp: 'gluster-mgmt = "glusterd"' |
There was a problem hiding this comment.
May want to make these matches a bit more robust ala: '^gluster-mgmt =.*' (or something alone those lines)... Just to ensure the replacement happens even if the default options changes subtly.
Madhu-1
approved these changes
Nov 8, 2018
kshlm
suggested changes
Nov 9, 2018
| value: GD2_ENDPOINTS | ||
|
|
||
| - name: Enable gluster-exporter.service | ||
| command: systemctl enable gluster-exporter.service |
There was a problem hiding this comment.
You should be using the service module instead of the command module. Any reason not to?
There was a problem hiding this comment.
referred other instance in the same file(Line 109)
- Depends on rpm spec file PR gluster/gluster-prometheus#26 - Nightly rpm building is setup gluster/centosci#36 - Depends of environment variable related PR gluster/gluster-prometheus#66 Signed-off-by: Aravinda VK <avishwan@redhat.com>
|
Updated to use "service" module instead of "command". @kshlm please review |
kshlm
approved these changes
Nov 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rpm spec to build the rpm gluster-prometheus#26
Support for
GD2_ENDPOINTSenvironment variable gluster-prometheus#66Signed-off-by: Aravinda VK avishwan@redhat.com