This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Name configurable addresses to be more meaningful #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the configurable options should represent the services provided or consumer of the port and not the protocol used. * Renamed 'rpcaddress' to 'peeraddress': Denotes the address used for peer to peer communication. * Renamed 'restaddress' to 'clientaddress': Denotes the address used by clients to communicate with glusterd2. Coincidentally, these are analogous to those provided by etcd. Signed-off-by: Prashanth Pai <ppai@redhat.com>
kshlm
suggested changes
Jan 17, 2017
There was a problem hiding this comment.
In a GlusterFS context a client address would imply something a GlusterFS client would connect to. Renaming 'restaddress' to 'clientaddress' would give it the wrong meaning. I would prefer retaining 'restaddress' as it is. I'm okay with the 'peeraddress' change.
That's exactly what this PR intends to do. Going forward, the port |
kshlm
approved these changes
Jan 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the configurable options should represent the services
provided or consumer of the port and not the protocol used.
for peer to peer communication.
used by clients to communicate with glusterd2.
Coincidentally, these are analogous to those provided by etcd.
Signed-off-by: Prashanth Pai ppai@redhat.com