cluster/ec: Do multi-threaded self-heal

BUG: 1368451 Change-Id: I5d6b91d714ad6906dc478a401e614115c89a8fbb Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/15083 Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Ashish Pandey <aspandey@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
gluster · Aug 24, 2016 · 56a79b3 · 56a79b3
1 parent 1edea95
commit 56a79b3
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 5 deletions.
diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c
@@ -957,9 +957,9 @@ struct volume_options options[] = {
           .min   = 1,
           .max   = 64,
           .default_value = "1",
-           .description = "Maximum number of threads SHD can use per local "
-                          "brick.  This can substantially lower heal times, "
-                          "but can also crush your bricks if you don't have "
+           .description = "Maximum number of parallel heals SHD can do per "
+                          "local brick. This can substantially lower heal times"
+                          ", but can also crush your bricks if you don't have "
                           "the storage hardware to support this."
         },
         { .key   = {"shd-wait-qlength"},

diff --git a/xlators/cluster/ec/src/ec-heald.c b/xlators/cluster/ec/src/ec-heald.c
@@ -275,6 +275,7 @@ ec_shd_index_sweep (struct subvol_healer *healer)
         ec_t          *ec     = NULL;
         int           ret     = 0;
         xlator_t      *subvol = NULL;
+        dict_t        *xdata  = NULL;
 
         ec = healer->this->private;
         subvol = ec->xl_list[healer->subvol];
@@ -287,9 +288,18 @@ ec_shd_index_sweep (struct subvol_healer *healer)
                 goto out;
         }
 
-        ret = syncop_dir_scan (subvol, &loc, GF_CLIENT_PID_SELF_HEALD,
-                               healer, ec_shd_index_heal);
+        xdata = dict_new ();
+        if (!xdata || dict_set_int32 (xdata, "get-gfid-type", 1)) {
+                ret = -ENOMEM;
+                goto out;
+        }
+
+        ret = syncop_mt_dir_scan (NULL, subvol, &loc, GF_CLIENT_PID_SELF_HEALD,
+                                  healer, ec_shd_index_heal, xdata,
+                                  ec->shd.max_threads, ec->shd.wait_qlength);
 out:
+        if (xdata)
+                dict_unref (xdata);
         loc_wipe (&loc);
 
         return ret;

diff --git a/xlators/cluster/ec/src/ec-heald.h b/xlators/cluster/ec/src/ec-heald.h
@@ -34,6 +34,8 @@ struct _ec_self_heald {
         gf_boolean_t            iamshd;
         gf_boolean_t            enabled;
         int                     timeout;
+        uint32_t                max_threads;
+        uint32_t                wait_qlength;
         struct subvol_healer   *index_healers;
         struct subvol_healer   *full_healers;
 };

diff --git a/xlators/cluster/ec/src/ec.c b/xlators/cluster/ec/src/ec.c
@@ -274,6 +274,10 @@ reconfigure (xlator_t *this, dict_t *options)
         GF_OPTION_RECONF ("read-policy", read_policy, options, str, failed);
         if (ec_assign_read_policy (ec, read_policy))
                 goto failed;
+        GF_OPTION_RECONF ("shd-max-threads", ec->shd.max_threads,
+                          options, uint32, failed);
+        GF_OPTION_RECONF ("shd-wait-qlength", ec->shd.wait_qlength,
+                          options, uint32, failed);
 
         return 0;
 failed:
@@ -613,6 +617,9 @@ init (xlator_t *this)
     if (ec_assign_read_policy (ec, read_policy))
             goto failed;
 
+    GF_OPTION_INIT ("shd-max-threads", ec->shd.max_threads, uint32, failed);
+    GF_OPTION_INIT ("shd-wait-qlength", ec->shd.wait_qlength, uint32, failed);
+
     this->itable = inode_table_new (EC_SHD_INODE_LRU_LIMIT, this);
     if (!this->itable)
             goto failed;
@@ -1374,5 +1381,23 @@ struct volume_options options[] =
               " subvolume using round-robin algo. 'gfid-hash' selects read"
               " subvolume based on hash of the gfid of that file/directory.",
     },
+    { .key   = {"shd-max-threads"},
+      .type  = GF_OPTION_TYPE_INT,
+      .min   = 1,
+      .max   = 64,
+      .default_value = "1",
+      .description = "Maximum number of parallel heals SHD can do per local "
+                      "brick.  This can substantially lower heal times, "
+                      "but can also crush your bricks if you don't have "
+                      "the storage hardware to support this."
+    },
+    { .key   = {"shd-wait-qlength"},
+      .type  = GF_OPTION_TYPE_INT,
+      .min   = 1,
+      .max   = 655536,
+      .default_value = "1024",
+      .description = "This option can be used to control number of heals"
+                     " that can wait in SHD per subvolume"
+    },
     { }
 };
diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-set.c b/xlators/mgmt/glusterd/src/glusterd-volume-set.c
@@ -3025,6 +3025,16 @@ struct volopt_map_entry glusterd_volopt_map[] = {
           .op_version  = GD_OP_VERSION_3_9_0,
           .type        = NO_DOC,
         },
+        { .key        = "disperse.shd-max-threads",
+          .voltype    = "cluster/disperse",
+          .op_version = GD_OP_VERSION_3_9_0,
+          .flags      = OPT_FLAG_CLIENT_OPT
+        },
+        { .key        = "disperse.shd-wait-qlength",
+          .voltype    = "cluster/disperse",
+          .op_version = GD_OP_VERSION_3_9_0,
+          .flags      = OPT_FLAG_CLIENT_OPT
+        },
         { .key         = NULL
         }
 };