Modify and return iatt (especially size and block-count) in shard in {F}SETXATTR fop

[KritikaDhananjay]

Description of problem:
{F}SETXATTR, in its fop signature does not really return iatt (pre or postbufs).
But posix translator unconditionally places the pre and post stats in its xattr-rsp dict and unwinds it.
Md-cache fetches these iatts to update its cache. However, this awareness that iatts are being sent in response is not built into shard. This results in md-cache caching the base shard size as the size of the entire file. Until cache-timeout, this incorrect size gets served leading to errors in the application.

The exact command to reproduce the issue:

The full output of the command that failed:

Expected results:
md-cache must receive the aggregated file size if it is sharded. This means, shard translator must replace ia_size and ia_blocks with the values fetched from trusted.glusterfs.shard.file-size xattr before unwinding the {F}SETXATTR fops.

Additional info:

- The output of the gluster volume info command:

Any volume with shard enabled.

- The operating system / glusterfs version:

[gluster-ant]

A patch https://review.gluster.org/24471 has been posted that references this issue.

features/shard: Aggregate size, block-count in iatt before unwinding setxattr

Posix translator returns pre and postbufs in the dict in {F}SETXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.

This patch fixes this problem.

Change-Id: I4da0eceb4235b91546df79270bcc0af8cd64e9ea
Fixes: #1243
Signed-off-by: Krutika Dhananjay kdhananj@redhat.com

[KritikaDhananjay]

Reopening and reusing this issue to address the same problem in {F}REMOVEXATTR.

[gluster-ant]

A patch https://review.gluster.org/24480 has been posted that references this issue.

features/shard: Aggregate file size, block-count before unwinding in removexattr

Posix translator returns pre and postbufs in the dict in {F}REMOVEXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.

This patch fixes this problem.

Change-Id: I4b2dd41ede472c5829af80a67401ec5a6376d872
Fixes: #1243
Signed-off-by: Krutika Dhananjay kdhananj@redhat.com

[gluster-ant]

A patch https://review.gluster.org/24567 has been posted that references this issue.

features/shard: Aggregate size, block-count in iatt before unwinding setxattr

Posix translator returns pre and postbufs in the dict in {F}SETXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.

This patch fixes this problem.

Change-Id: I4da0eceb4235b91546df79270bcc0af8cd64e9ea
Fixes: #1243
Signed-off-by: Krutika Dhananjay kdhananj@redhat.com
(cherry picked from commit 29ec66c)

[gluster-ant]

A patch https://review.gluster.org/24568 has been posted that references this issue.

features/shard: Aggregate size, block-count in iatt before unwinding setxattr

Posix translator returns pre and postbufs in the dict in {F}SETXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.

This patch fixes this problem.

Change-Id: I4da0eceb4235b91546df79270bcc0af8cd64e9ea
Fixes: #1243
Signed-off-by: Krutika Dhananjay kdhananj@redhat.com
(cherry picked from commit 29ec66c)

[gluster-ant]

A patch https://review.gluster.org/24629 has been posted that references this issue.

features/shard: Aggregate file size, block-count before unwinding removexattr

Posix translator returns pre and postbufs in the dict in {F}REMOVEXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.

This patch fixes this problem.

Change-Id: I4b2dd41ede472c5829af80a67401ec5a6376d872
Fixes: #1243
Signed-off-by: Krutika Dhananjay kdhananj@redhat.com
(cherry picked from commit 3251952)

[gluster-ant]

A patch https://review.gluster.org/24653 has been posted that references this issue.

features/shard: Aggregate file size, block-count before unwinding removexattr

Posix translator returns pre and postbufs in the dict in {F}REMOVEXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.

This patch fixes this problem.

Change-Id: I4b2dd41ede472c5829af80a67401ec5a6376d872
Fixes: #1243
Signed-off-by: Krutika Dhananjay kdhananj@redhat.com
(cherry picked from commit 3251952)

[stale]

Thank you for your contributions.
Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity.
It will be closed in 2 weeks if no one responds with a comment here.

[mykaul]

@VHariharmath-rh - you may want to look at this.

[vh05]

sure. I will take a look

[stale]

Thank you for your contributions.
Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity.
It will be closed in 2 weeks if no one responds with a comment here.

[stale]

Closing this issue as there was no update since my last update on issue. If this is an issue which is still valid, feel free to open it.