Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHEL 8.1] [Input/output error] observed in remove-brick operation #1371

Closed
tshacked opened this issue Jul 15, 2020 · 1 comment
Closed

[RHEL 8.1] [Input/output error] observed in remove-brick operation #1371

tshacked opened this issue Jul 15, 2020 · 1 comment
Labels
Type:Bug

Comments

@tshacked
Copy link
Contributor

Upstream clone of https://bugzilla.redhat.com/show_bug.cgi?id=1815462
@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/24712 has been posted that references this issue.

cluster/dht: suppress misleading file migration error for node not supposed to migrate file

A rebalance process does a lookup for every file in the directory it is processing
before checking if it supposed to migrate the file.
In this issue there are two rebalance processses running on a replica subvol:
R1 is migrating the FILE.
R2 is not supposed to migrate the FILE, but it does a lookup and finds a stale linkfile.
Then, it tries to unlink the stale linkfile and gets EBUSY as the linkfile fd is open due R1 migration.
As a result a misleading error msg about FILE migration failure due EBUSY is logged in R2 logfile.

Fix: suppress this error in case it occured in a node that is not supposed to migrate the file.

fixes: #1371
Change-Id: I37832b404e2b0cc40ac5caf45f14c32c891e71f3
Signed-off-by: Tamar Shacked tshacked@redhat.com

csabahenk pushed a commit to csabahenk/glusterfs that referenced this issue Mar 7, 2023
@tshacked @sunilheggodu
cluster/dht: suppress file migration error for node not supposed to m…
a5da8bb 
…igrate file

A rebalance process does a lookup for every file in the dir it is processing
before checking if it supposed to migrate the file.
In this issue there are two rebalance processses running on a replica subvol:
R1 is migrating the FILE.
R2 is not supposed to migrate the FILE, but it does a lookup and
   finds a stale linkfile which is mostly due to a stale layout.
   Then, it tries to unlink the stale linkfile and gets EBUSY
   as the linkfile fd is open due R1 migration.
   As a result a misleading error msg about FILE migration failure
   due EBUSY is logged in R2 logfile.

Fix:
suppress the error in case it occured in a node that
is not supposed to migrate the file.

Backport of:
> Upstream-patch-link: https://review.gluster.org/#/c/glusterfs/+/24712/
> fixes: gluster#1371
> Change-Id: I37832b404e2b0cc40ac5caf45f14c32c891e71f3
> Signed-off-by: Tamar Shacked <tshacked@redhat.com>

BUG: 1815462
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
Change-Id: I915ee8e7470d85a849b198bfa7d58d368a246aae
Reviewed-on: https://code.engineering.redhat.com/gerrit/c/rhs-glusterfs/+/245401
Tested-by: RHGS Build Bot <nigelb@redhat.com>
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gluster-ant @tshacked