Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard refcounting functions #156

Closed
nixpanic opened this issue Apr 6, 2017 · 3 comments
Closed

Use standard refcounting functions #156

nixpanic opened this issue Apr 6, 2017 · 3 comments
Labels
FA: Technical Debt
Milestone
Release 3.11 (STM)

Comments

@nixpanic
Copy link
Member

nixpanic commented Apr 6, 2017

Many structures use their own refcounting implementation. Many of these use a lock on the structure, which is not optimal for modern architectures. We have a standard way of doing refcounting in libglusterfs/src/refcount.h and this should be used where possible.

Any structures that have *_ref() and *_unref() functions are candidates for conversion.
@amarts amarts modified the milestone: Release 3.11 (STM) Apr 17, 2017
@ShyamsundarR ShyamsundarR added this to Release 3.11 in Releases Apr 26, 2017
@ShyamsundarR
Copy link
Contributor

Dropping a note, parts of this would be done out for 3.11 and the feature would continue to 3.12. We still want to call this out in the 3.11 release notes though.

@nixpanic
Copy link
Member Author

glfs_object used by the handle functions in gfapi is a good candidate too. It currently does a sortof reference counting on glfs_object->inode and that is difficult to track as it is one additional indirection.

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/17390 has been posted that references this issue.
Commit message: doc: Updated release notes for several features/changes in 3.11.0

mscherer pushed a commit that referenced this issue May 26, 2017
@ShyamsundarR
doc: Updated release notes for several features/changes in 3.11.0
3efadd8 
Updates #61, Updates #156
Fixes #166, Fixes #167

Change-Id: I031bf944493b959d44c97fb0ddf7c1b80e53bdda
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: https://review.gluster.org/17390
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
@amarts amarts closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FA: Technical Debt
Projects
None yet
Milestone
Release 3.11 (STM)
Development

No branches or pull requests
4 participants
@nixpanic @amarts @ShyamsundarR @gluster-ant