Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One of the rebal-throttle tests uses the wrong variable #2315

Closed
jamielinux opened this issue Apr 7, 2021 · 0 comments · Fixed by #2316
Closed

One of the rebal-throttle tests uses the wrong variable #2315

jamielinux opened this issue Apr 7, 2021 · 0 comments · Fixed by #2316

Comments

@jamielinux
Copy link
Contributor

Description of problem:

Test specifies THORTTLE_LEVEL on line 47, then uses THROTTLE_LEVEL on line 49.

glusterfs/tests/basic/distribute/throttle-rebal.t

Lines 46 to 50 in e84fc53

#Setting thorttle number to be more than the number of cores should fail
THORTTLE_LEVEL=$((cores+1))
TEST echo $THORTTLE_LEVEL
EXPECT "failed" set_throttle $THROTTLE_LEVEL
EXPECT "$cores" echo `$CLI volume info | grep rebal-throttle | awk '{print $2}'`

@jamielinux jamielinux mentioned this issue Apr 7, 2021
Merged
amarts pushed a commit that referenced this issue Apr 8, 2021
@jamielinux
tests: Fix incorrect variables in throttle-rebal.t (#2316)
7a9f7cb 
The final test doesn't test what it means to test. It still fails as
expected, but only because at this point `THROTTLE_LEVEL` is still set
to `garbage`.

Easily fixed by correcting the typos in the variable names, and thus
fixes #2315

Signed-off-by: Jamie Nguyen <j@jamielinux.com>
chenglin130 pushed a commit to chenglin130/glusterfs that referenced this issue Apr 13, 2021
@jamielinux @chenglin130
tests: Fix incorrect variables in throttle-rebal.t (gluster#2316)
15d3471 
The final test doesn't test what it means to test. It still fails as
expected, but only because at this point `THROTTLE_LEVEL` is still set
to `garbage`.

Easily fixed by correcting the typos in the variable names, and thus
fixes gluster#2315

Signed-off-by: Jamie Nguyen <j@jamielinux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Fix incorrect variables in throttle-rebal.t
1 participant
@jamielinux