Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use an iobuf pool for the CLI #2963

Closed
mykaul opened this issue Nov 19, 2021 · 0 comments · Fixed by #2966
Closed

Do not use an iobuf pool for the CLI #2963

mykaul opened this issue Nov 19, 2021 · 0 comments · Fixed by #2966
Labels
release 11 Type:Enhancement

Comments

@mykaul
Copy link
Contributor

mykaul commented Nov 19, 2021

There's really no need for a whole iobuf pool with all its allocations, just for the CLI command invocation.
mykaul pushed a commit to mykaul/glusterfs that referenced this issue Nov 19, 2021
cli.c: do not use iobuf pool
4dc53b9 
There's really no need to allocate an iobuf pool for the CLI.
It's a waste of memory and CPU to do all this allocation for CLI command
invocation.

Fixes: gluster#2963
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
@mykaul mykaul mentioned this issue Nov 19, 2021
Merged
mykaul pushed a commit to mykaul/glusterfs that referenced this issue Nov 19, 2021
cli.c: do not use iobuf pool
3e5e8d1 
There's really no need to allocate an iobuf pool for the CLI.
It's a waste of memory and CPU to do all this allocation for CLI command
invocation.

Fixes: gluster#2963
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
mohit84 pushed a commit that referenced this issue Mar 5, 2022
cli.c: do not use iobuf pool (#2966)
2bd36b3 
* cli.c: do not use iobuf pool

There's really no need to allocate an iobuf pool for the CLI.
It's a waste of memory and CPU to do all this allocation for CLI command
invocation.

Fixes: #2963
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>

* iobuf.c: make iobuf_get_from_small() non static and use in cli

Re-use the function, by making it non-static.

(Remove the unneeded use of 'ret' in the function while at it).

Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release 11 Type:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli.c: do not use iobuf pool mykaul/glusterfs
1 participant
@mykaul