New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not explicitly call strerror(errnum) when logging #782
Labels
assigned
This bug has at least one 'assignee'. It will not get 'stale' label.
Comments
Thank you for your contributions. |
unstale please |
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 16, 2021
As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: gluster#782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 16, 2021
As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: gluster#782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 17, 2021
As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: gluster#782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 17, 2021
As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: gluster#782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 18, 2021
As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: gluster#782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 18, 2021
As per review comments removed trailing spaces and joined some strings. Fixes: gluster#782 Change-Id: Ibe406830c9bde9ffd85d48749f43c755ef54ac8e Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 18, 2021
As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: gluster#782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 18, 2021
As per review comments removed trailing spaces and joined some strings. Fixes: gluster#782 Change-Id: Ibe406830c9bde9ffd85d48749f43c755ef54ac8e Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 18, 2021
As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: gluster#782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
rkothiya
pushed a commit
to rkothiya/glusterfs
that referenced
this issue
Feb 18, 2021
As per review comments removed trailing spaces and joined some strings. Fixes: gluster#782 Change-Id: Ibe406830c9bde9ffd85d48749f43c755ef54ac8e Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
amarts
added
the
assigned
This bug has at least one 'assignee'. It will not get 'stale' label.
label
May 28, 2021
rkothiya
pushed a commit
that referenced
this issue
Jun 17, 2021
* logging: Avoiding a call to strerror while logging As strerror is already printed if there is an errnum avoiding a redundant call to it while logging. Fixes: #782 Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2 Signed-off-by: Rinku Kothiya <rkothiya@redhat.com> * logging: Avoiding a call to strerror while logging As per review comments removed trailing spaces and joined some strings. Fixes: #782 Change-Id: Ibe406830c9bde9ffd85d48749f43c755ef54ac8e Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, instead of:
Use:
As I believe, that errno is propagated all the way in the logging to finally become the footer:
The text was updated successfully, but these errors were encountered: