stripe cleanup: Remove the option from create and add-brick cmds #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run regression |
amarts
reviewed
Nov 18, 2020
| @@ -5841,8 +5833,6 @@ glusterd_get_state(rpcsvc_request_t *req, dict_t *dict) | |||
|
|
|||
| fprintf(fp, "Volume%d.snap_count: %" PRIu64 "\n", count, | |||
| volinfo->snap_count); | |||
| fprintf(fp, "Volume%d.stripe_count: %d\n", count, | |||
| volinfo->stripe_count); | |||
There was a problem hiding this comment.
this removal may result in checksum mismatch during update... can you check if we need to write it regardless.
@mohit84 please confirm.
Sheetalpamecha
force-pushed
the
issue457
branch
from
4a7e9db
to
709b130
Compare
|
/run regression |
1 similar comment
|
/run regression |
amarts
previously approved these changes
Dec 4, 2020
|
Hi @mohit84, Review approval please if you don't see any other issue with this patch. |
Yes sheetal please do it |
|
/run regression |
|
/recheck smoke |
This patch aims to remove the code for stripe option instead of keeping a default values of stripe/stripe-count variables and setting and getting dict options and similar redundant operations. Also removing tests for stripe volumes that have been already marked bad. Updates: gluster#1000 Change-Id: Ic2b3cabd671f0c8dc0521384b164c3078f7ca7c6 Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
tests/000-flaky/basic_changelog_changelog-snapshot.t was failing due to 0 return value Change-Id: I8ea0443669c63768760526db5aa1f205978e1dbb Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
Change-Id: I49f3da4f106c55f9da20d0b0a299275a19daf4ba
Sheetalpamecha
force-pushed
the
issue457
branch
from
9ef5745
to
947926e
Compare
Change-Id: I83bae85d10c8c5b3c66f56c9f8de1ec81d0bbc95
|
/run regression |
amarts
approved these changes
Jan 4, 2021
mohit84
approved these changes
Jan 5, 2021
Shwetha-Acharya
added a commit
to Shwetha-Acharya/glusterfs
that referenced
this pull request
May 10, 2022
…mds (gluster#1812)" This reverts commit 1d74669. Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to remove the code for stripe option instead
of keeping a default values of stripe/stripe-count variables and
setting and getting dict options and similar redundant operations.
Also removing tests for stripe volumes that have been already
marked bad.
Updates: #1000
Change-Id: Ic2b3cabd671f0c8dc0521384b164c3078f7ca7c6
Signed-off-by: Sheetal Pamecha spamecha@redhat.com