configure: Enable ltcmalloc_minimal instead of ltcmalloc #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gluster process is getting crashed while ltcmalloc library is loaded/unloaled in two different threads.The process is getting crashed during access of tls variables in heap profiler api. Though the issue is already fixed(gperftools/gperftools#786) in gperftool-9 but the rpm has not been build for rhel-(7|8).The heap profile api is access only an application is linked with libtcamlloc. Solution: To avoid a crash linked library with ltcmalloc_minimal Fixes: gluster#2971 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
/run regression |
mykaul
approved these changes
Dec 1, 2021
I have already tested, it solves the issue. |
|
The change looks good to me. Given the criticality, I'll merge it. However I would try to implement a more dynamic approach by checking the tcmalloc version at configure time and use it to decide to which library to link (tcmalloc vs tcmalloc_minimal). Otherwise we'll permanently lose profiling and checking capabilities that could be very useful for debugging and improving performance. |
xhernandez
approved these changes
Dec 1, 2021
mohit84
added a commit
to mohit84/glusterfs
that referenced
this pull request
Dec 2, 2021
The gluster process is getting crashed while ltcmalloc library init/fini related functions are called in two different threads during a library loaded/unloaded.The process is getting crashed during access of tls variables in heap profiler api. Though the issue is already fixed(gperftools/gperftools#786) in gperftool-9 but the rpm has not been build for rhel-(7|8). The heap profile api is access by an application while application is linked with libtcamlloc. Solution: To avoid a crash linked library with ltcmalloc_minimal > Fixes: gluster#2971 > Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> > (Cherry picked from upstream gluster#2994) Fixes: gluster#2971 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
mohit84
added a commit
that referenced
this pull request
Dec 23, 2021
The gluster process is getting crashed while ltcmalloc library init/fini related functions are called in two different threads during a library loaded/unloaded.The process is getting crashed during access of tls variables in heap profiler api. Though the issue is already fixed(gperftools/gperftools#786) in gperftool-9 but the rpm has not been build for rhel-(7|8). The heap profile api is access by an application while application is linked with libtcamlloc. Solution: To avoid a crash linked library with ltcmalloc_minimal > Fixes: #2971 > Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> > (Cherry picked from upstream #2994) Fixes: #2971 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gluster process is getting crashed while ltcmalloc library init/fini related functions are called in two different
threads during a library loaded/unloaded.The process is getting crashed during access of tls variables in heap profiler
api. Though the issue is already fixed(gperftools/gperftools#786) in gperftool-9 but the rpm has not been build for rhel-(7|8).The heap profile api is access by an application while application is linked with libtcamlloc.
Solution: To avoid a crash linked library with ltcmalloc_minimal
Fixes: #2971
Signed-off-by: Mohit Agrawal moagrawa@redhat.com