core: brick process is getting SIGSEGV during inode_unref #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The brick process is getting crashed due to stack overflow while unref namespace inode, the ns inode was introduced by the patch ((gluster#1763) Solution: __inode_destroy is calling inode_unref that is again calling inode_unref become a recursive call and eventually a brick process is getting crashed. To avoid a crash for namespace inode call only __inode_ref. Fixes: gluster#4295 Change-Id: If5deb06b726a5e7dfedd2784bddcef81e6e5d7d9 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
/run regression |
xhernandez
approved these changes
Jan 30, 2024
amarts
approved these changes
Jan 30, 2024
|
recheck smoke |
mohit84
added a commit
to mohit84/glusterfs
that referenced
this pull request
Feb 1, 2024
The brick process is getting crashed due to stack overflow while unref namespace inode, the ns inode was introduced by the patch ((gluster#1763) Solution: __inode_destroy is calling inode_unref that is again calling inode_unref become a recursive call and eventually a brick process is getting crashed. To avoid a crash for namespace inode call only __inode_ref. > Fixes: gluster#4295 > Change-Id: If5deb06b726a5e7dfedd2784bddcef81e6e5d7d9 > Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> > (Cherry picked from commit 80ecbba) > (Reviewed on upstream link gluster#4302) Fixes: gluster#4295 Change-Id: If5deb06b726a5e7dfedd2784bddcef81e6e5d7d9 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brick process is getting crashed due to stack overflow while unref namespace inode, the ns inode
was introduced by the patch ((#1763)
Solution: __inode_destroy is calling inode_unref that is again calling inode_unref become a
recursive call and eventually a brick process is getting crashed. To avoid a crash for namespace
inode call only __inode_ref.
Fixes: #4295
Change-Id: If5deb06b726a5e7dfedd2784bddcef81e6e5d7d9