Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for user to stop streaks from being broken on days when there are no cards due #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shoaib281
Copy link

Description

From issue #129, one feature request has been that if 0 cards were due on a particular day, the streak should continue, I've made an option for this in the settings so users can have this feature enabled if they do so wish (it is disabled by default).

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

  • I've read and understood the contribution guidelines
  • I've tested my changes against at least one of the following Anki builds:
    • Latest standard Anki 2.1 binary build
    • Latest alternative Anki 2.1 binary build
  • I've tested my changes on at least one of the following platforms:
    • Linux, version:
    • Windows, version:
    • macOS, version:
  • My changes potentially affect non-desktop platforms, of which I've tested:
    • AnkiMobile, version:
    • AnkiDroid, version:
    • AnkiWeb

@glutanimate glutanimate self-requested a review December 9, 2021 16:16
@glutanimate
Copy link
Owner

Hey shabbs,

My apologies for taking ages to get to this. Thanks for the contribution! Makes perfect sense to have an option like that in the add-on.

Will see if I can resolve the merge conflicts and give the changes a try, and will then get back to you.

@glutanimate glutanimate self-assigned this May 19, 2022
@glutanimate glutanimate added the enhancement New feature or request label May 19, 2022
@techvio-dev
Copy link

techvio-dev commented Apr 26, 2023

Is there any progress on that @glutanimate ? this option is a must in this add-on.

@BjoernLudwigPTB
Copy link

I would love that option as well. Do you see any chance, it might be merged @glutanimate? Can we do anything to get the remaining work done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants