Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-304 CSUB-322 CSUB-315 Task-Scheduler for Creditcoin #773

Merged
merged 29 commits into from
Dec 8, 2022

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Nov 15, 2022

Description of proposed changes:

Reopen #656 just in case it fixes CI.

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@CAGS295 CAGS295 mentioned this pull request Nov 15, 2022
9 tasks
@CAGS295 CAGS295 force-pushed the feature/CSUB-304 branch 5 times, most recently from cbc2ebf to ea19fc5 Compare November 16, 2022 22:46
@github-actions
Copy link

For full LLVM coverage report click here!

@CAGS295 CAGS295 marked this pull request as ready for review November 16, 2022 23:11
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase to resolve the conflicts but other than that it looks good to me.

@CAGS295 CAGS295 force-pushed the feature/CSUB-304 branch 2 times, most recently from 501ae3b to 92f81c1 Compare November 22, 2022 01:16
Copy link
Contributor

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First few comments, I'm not done reviewing the new code so I'll re-review once I'm back

pallets/creditcoin/src/migrations/mod.rs Show resolved Hide resolved
pallets/creditcoin/src/lib.rs Show resolved Hide resolved
pallets/creditcoin/src/mock.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/CSUB-264@fb5df5d). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             feature/CSUB-264     #773   +/-   ##
===================================================
  Coverage                    ?   79.40%           
===================================================
  Files                       ?       64           
  Lines                       ?    10230           
  Branches                    ?        0           
===================================================
  Hits                        ?     8123           
  Misses                      ?     2107           
  Partials                    ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CAGS295 added a commit that referenced this pull request Dec 21, 2022
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
nathanwhit pushed a commit that referenced this pull request Dec 21, 2022
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
nathanwhit pushed a commit that referenced this pull request Dec 22, 2022
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
nathanwhit pushed a commit that referenced this pull request Dec 23, 2022
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
CAGS295 added a commit that referenced this pull request Dec 25, 2022
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
CAGS295 added a commit that referenced this pull request Dec 25, 2022
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
CAGS295 added a commit that referenced this pull request Jan 3, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
CAGS295 added a commit that referenced this pull request Jan 4, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 5, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 12, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 13, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 13, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 17, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 18, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 20, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Jan 31, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Feb 2, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Feb 10, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Feb 10, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Feb 10, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Feb 22, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Apr 3, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Apr 13, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Apr 20, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Apr 21, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Apr 25, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request Apr 28, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request May 1, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
atodorov pushed a commit that referenced this pull request May 4, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
nathanwhit pushed a commit that referenced this pull request Jun 7, 2023
* Connect task-scheduler interface

* move IntoBounded to extensions

* migrate `PendingTasks` storage

* remove make id functions in favor of From impl

* types: transfers

* types: CollectedCoins

* fix duplicated id constructors

* mocked runtime

* Authority Interface

* port nonce tests

* updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing

* fix `register_transfer_ocw_fail_to_send`

* use task-scheduler in creditcoin's mocked runtime

* port `offchain_signed_tx_works`

* `remove_authority_works_for_root() fix`+ `add_authority_works_for_root`

* port `offchain_worker_logs_error_when_transfer_validation_errors`

* port `effective_guard_lifetime_until_task_expiration`

* port `completed_oversubscribed_tasks_are_skipped`

* port `ocw_retries`

* port` task_deadline_oversubscription`

* port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled`

* rename `duplicate_retry_fail_and_succeed`

* change keystore id to 'gots'

* move task-scheduler

* Benchmarks

* Update pallets/offchain-task-scheduler/src/ocw/tests.rs

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

* remove unused code

* consistent weight update in `migrate`

Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com>

Update creditcoin-js interface

format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants