Update createAddressId in creditcoin-js to match current behavior

[nathanwhit]

Description of proposed changes:

Practical tips for PR review & merge:

• All GitHub Actions report PASS
• Newly added code/functions have unit tests
  • Coverage tools report all newly added lines as covered
  • The positive scenario is exercised
  • Negative scenarios are exercised, e.g. assert on all possible errors
  • Assert on events triggered if applicable
  • Assert on changes made to storage if applicable
• Modified behavior/functions - try to make sure above test items are covered
• Integration tests are added if applicable/needed

[github-actions]

For full LLVM coverage report click here!

[codecov-commenter]

Codecov Report

Merging #775 (63205e7) into dev (8c80f5b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #775   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files          50       50           
  Lines       10056    10056           
=======================================
  Hits         8042     8042           
  Misses       2014     2014           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[atodorov]

Test job https://github.com/gluwa/creditcoin/actions/runs/3499846864/jobs/5861862812 from #776 failed with

FAIL src/test/collect-coins.test.ts (63.195 s)
  ● CollectCoins › persist › fee is min 0.01 CTC but bypassed by OCW

    creditcoin.NonExistentAddress: The specified address does not exist.

      17 |     status: any,
      18 | ): Promise<void> => {
    > 19 |     expectNoDispatchError(api, dispatchError);
         |     ^
      20 |     if (status.isInBlock) {
      21 |         const balancesWithdraw = events.find(({ event: { method, section } }) => {
      22 |             return section === 'balances' && method === 'Withdraw';

which is expected b/c the address indeed doesn't exist. Retesting with this patch applied.

[atodorov]

Tests are passing -> #776 (comment)