-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for createAddressId() #776
Conversation
116ac13
to
e9e0136
Compare
For full LLVM coverage report click here! |
Codecov Report
@@ Coverage Diff @@
## dev #776 +/- ##
=======================================
Coverage 79.97% 79.97%
=======================================
Files 50 50
Lines 10056 10056
=======================================
Hits 8042 8042
Misses 2014 2014 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e9e0136
to
979459e
Compare
979459e
to
627d9be
Compare
@nathanwhit even after picking up your commit from #775 and bumping creditcoin-js version I am seeing a failure in this test:
Will continue debugging but pointers are welcome. |
ce5b590
to
2c95633
Compare
https://github.com/gluwa/creditcoin/actions/runs/3525098639/jobs/5911383884 failed as expected:
Retesting with the commit from #775 -> PASS, see https://github.com/gluwa/creditcoin/actions/runs/3525500553/jobs/5912299101 |
537d1cd
to
d4f323f
Compare
Description of proposed changes:
Practical tips for PR review & merge: