Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-312: Sanity test runtime upgrades migrations #816

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

atodorov
Copy link
Collaborator

Description of proposed changes:

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov changed the base branch from dev to testnet December 14, 2022 10:46
@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch from 33bdfe5 to 2835964 Compare December 14, 2022 10:47
@github-actions
Copy link

For full LLVM coverage report click here!

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #816 (9607425) into dev (deda03d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #816   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files          68       68           
  Lines       10768    10768           
=======================================
  Hits         8411     8411           
  Misses       2357     2357           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch from 6300f9e to 55a3f4b Compare December 14, 2022 13:01
@atodorov
Copy link
Collaborator Author

FTR the stock GitHub runner takes 50 mins to import the blocks:
https://github.com/gluwa/creditcoin/actions/runs/3694062118/jobs/6254796466

The self-hosted runner is less powerful and OOMs after 64 mins, never completing the job:
https://github.com/gluwa/creditcoin/actions/runs/3695038321/jobs/6256942161 NOTE: need to retry after it has been beefed up.

@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch 7 times, most recently from 74cc073 to 36d3209 Compare December 22, 2022 12:27
@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch 2 times, most recently from b7276e3 to 1cbd43b Compare December 23, 2022 15:23
@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch 3 times, most recently from a5d0ac9 to 93ce531 Compare January 12, 2023 13:27
@atodorov atodorov mentioned this pull request Jan 12, 2023
9 tasks
@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch 6 times, most recently from fca2647 to 5c936a4 Compare January 17, 2023 14:16
@atodorov
Copy link
Collaborator Author

Needs #889 merged first!

@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch 4 times, most recently from 6e0dbf0 to cb17f95 Compare January 20, 2023 14:10
@atodorov
Copy link
Collaborator Author

Logs from testing against testnet - https://github.com/gluwa/creditcoin/actions/runs/3968377925/jobs/6802244194
Logs from testing against main - https://github.com/gluwa/creditcoin/actions/runs/3968875445/jobs/6804989343

All PASS.

Note: the snapshot data used for testing is only for mainnet, I just copied the file and renamed it to include -testnet- in the file name. We'll need to regenerate new snapshots for proper testing.

@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch from cb17f95 to 82da234 Compare January 20, 2023 17:41
@atodorov atodorov changed the base branch from testnet to dev January 20, 2023 17:41
@atodorov atodorov force-pushed the test/CSUB-312-add-tests-for-runtime-upgrades branch from 82da234 to 9607425 Compare January 20, 2023 17:41
@atodorov atodorov marked this pull request as ready for review January 20, 2023 17:41
@atodorov atodorov changed the title CSUB-312: Testing runtime upgrades duration CSUB-312: Sanity test runtime upgrades migrations Jan 20, 2023
@atodorov atodorov merged commit 584a33e into dev Jan 23, 2023
@atodorov atodorov deleted the test/CSUB-312-add-tests-for-runtime-upgrades branch January 23, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants