Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-312: Enable try-runtime #819

Merged
merged 6 commits into from
Jan 11, 2023
Merged

CSUB-312: Enable try-runtime #819

merged 6 commits into from
Jan 11, 2023

Conversation

nathanwhit
Copy link
Contributor

Description of proposed changes:
There were a few missing pieces. Still not entirely sure how to use it though.

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@github-actions
Copy link

For full LLVM coverage report click here!

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #819 (86ef7db) into dev (39fb3ef) will decrease coverage by 0.01%.
The diff coverage is 5.88%.

@@            Coverage Diff             @@
##              dev     #819      +/-   ##
==========================================
- Coverage   78.14%   78.13%   -0.02%     
==========================================
  Files          68       68              
  Lines       10666    10668       +2     
==========================================
  Hits         8335     8335              
- Misses       2331     2333       +2     
Impacted Files Coverage Δ
node/src/cli.rs 35.71% <ø> (ø)
node/src/command.rs 0.00% <0.00%> (ø)
pallets/creditcoin/src/lib.rs 81.70% <ø> (ø)
pallets/creditcoin/src/migrations/mod.rs 0.00% <ø> (ø)
pallets/creditcoin/src/migrations/v6.rs 89.21% <ø> (ø)
runtime/src/lib.rs 23.78% <6.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CAGS295
CAGS295 previously approved these changes Dec 14, 2022
atodorov
atodorov previously approved these changes Dec 15, 2022
@atodorov atodorov enabled auto-merge (rebase) December 15, 2022 12:19
@atodorov atodorov changed the title Enable try-runtime CSUB-312: Enable try-runtime Dec 16, 2022
CAGS295
CAGS295 previously approved these changes Dec 19, 2022
pallets/creditcoin/src/migrations/mod.rs Show resolved Hide resolved
pallets/creditcoin/src/migrations/mod.rs Show resolved Hide resolved
atodorov
atodorov previously approved these changes Dec 21, 2022
@atodorov atodorov dismissed stale reviews from CAGS295 and themself via 7bc464b January 9, 2023 15:51
@atodorov
Copy link
Contributor

atodorov commented Jan 9, 2023

Rebased to latest dev!

CAGS295
CAGS295 previously approved these changes Jan 10, 2023
@atodorov atodorov enabled auto-merge (rebase) January 10, 2023 08:09
@atodorov atodorov requested a review from CAGS295 January 10, 2023 14:48
@atodorov atodorov merged commit fd1e262 into dev Jan 11, 2023
@atodorov atodorov deleted the try-runtime branch January 11, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants