Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-373: Enable Build WASM Runtime job for PRs againt dev/tesnet #876

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jan 6, 2023

automatic update of WASM blob will still happen only on merged to dev

Description of proposed changes:

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov changed the title Enable Build WASM Runtime job for PRs againt dev/tesnet CSUB-373: Enable Build WASM Runtime job for PRs againt dev/tesnet Jan 6, 2023
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

For full LLVM coverage report click here!

@codecov-commenter
Copy link

Codecov Report

Merging #876 (6f0981c) into dev (cd2e16a) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #876      +/-   ##
==========================================
+ Coverage   78.07%   78.14%   +0.07%     
==========================================
  Files          67       68       +1     
  Lines       10617    10666      +49     
==========================================
+ Hits         8289     8335      +46     
- Misses       2328     2331       +3     
Impacted Files Coverage Δ
primitives/src/lib.rs 93.33% <0.00%> (ø)
pallets/creditcoin/src/lib.rs 81.70% <0.00%> (ø)
pallets/creditcoin/src/migrations/v6.rs 89.21% <0.00%> (ø)
primitives/src/vrf.rs 93.87% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

automatic update of WASM blob will still happen only on merged to dev
@nathanwhit nathanwhit self-requested a review January 6, 2023 22:50
@nathanwhit nathanwhit merged commit f0fa693 into dev Jan 6, 2023
@nathanwhit nathanwhit deleted the enable_srtool_for_oprs branch January 6, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants