Use std::unique_ptr for pimpl idiom in HTTP client.

glynos · Dec 24, 2014 · 4e0add7 · 4e0add7
1 parent ff5f714
commit 4e0add7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/http/src/http/v2/client/client.cpp b/http/src/http/v2/client/client.cpp
@@ -397,7 +397,7 @@ namespace network {
           : pimpl_(new impl(std::move(mock_resolver),
                             std::move(mock_connection), options)) {}
 
-      client::~client() { delete pimpl_; }
+      client::~client() { }
 
       std::future<response> client::execute(request req,
                                             request_options options) {

diff --git a/http/src/http/v2/client/client_errors.cpp b/http/src/http/v2/client/client_errors.cpp
@@ -9,7 +9,7 @@
 
 namespace network {
   namespace http {
-    namespace v2 {
+  inline namespace v2 {
       class client_category_impl : public std::error_category {
 
        public:

diff --git a/http/src/network/http/v2/client/client.hpp b/http/src/network/http/v2/client/client.hpp
@@ -395,7 +395,7 @@ class client {
 private:
 
   struct impl;
-  impl *pimpl_;
+  std::unique_ptr<impl> pimpl_;
 
 };
 } // namespace v2

diff --git a/uri b/uri