Update rspec matchers and clean up spec folder #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the rspec matchers from the 2.x syntax to the 3.x. It also changes the spec descriptions to the third person present tense (i.e. 'it does something' vs 'it should do something') - see http://betterspecs.org/#should.
I've always found it best to keep the spec file structure the same as the library file structure. It makes it easy to see what has/hasn't been spec'd, where specific specs should live, etc. This moves some existing specs into the appropriate place and creates placeholders for others. This also moves the imap extensions out into the Gmail namespace which makes a bit more sense then just having it be a standalone class living in the /gmail/client folder. Sidenote: We could probably better split out the specs and DRY them up a bit. Especially the individual client specs.
jeffcarbs
changed the title
bootstraponline
added a commit
that referenced
this pull request
Jan 22, 2015
Update rspec matchers and clean up spec folder
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #155
Remove deprecated rspec matchers
This changes the rspec matchers from the 2.x syntax to the 3.x. It also changes the spec descriptions to the third person present tense (i.e. 'it does something' vs 'it should do something') - see http://betterspecs.org/#should.
Reorganized the project (mostly specs)
I've always found it best to keep the spec file structure the same as the library file structure. It makes it easy to see what has/hasn't been spec'd, where specific specs should live, etc. This commit moves some existing specs into the appropriate place and creates placeholders for others.
This also moves the
ImapExtensionsinto theGmailnamespace which makes a bit more sense then just having it be a standalone class living in the/gmail/clientfolder.Sidenote: We could probably better split out the specs and DRY them up a bit. Especially the individual client specs.
...aaaand changed
GMailtoGmailthroughout.