-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re: why I stopped contributing to vundle #378
Comments
In past, I forked your plugin and use it. Yes. https://github.com/Shougo/neobundle.vim If neobundle stops Vundle development, I must apologize. It may be wrong way. |
In first version, "it is based on Vundle", Yes(it is documented). I can add "based on Vundle in first version" in the documentation if it is better. |
Can you tel me the problem code in latest neobundle? If the problem is documentation or license, I will fix it. |
I added the copyright and fix the "inspired". |
I didn't not undestand OSS's license, so I have mistaked. |
https://github.com/gmarik/vundle/pulls Vundle has many pull request for features.
@gmarik does not want to add extra features I think. |
@Shougo so, what exactly did you do? Copy the repo, pull in all the pull requests on top of it, and write your name all over it? |
Sorry, I have not much time to explain it now. And I'm not good English writer. It is two points in this problems.
It is my fault. I did not understand this problem until yesterday. Sorry, It must be fixed. I want to fix problems.
I can contribute it. But I think it is not acceptable. It is really big features(see neobundle code). |
@Shougo thanks for quick response… IMO it'll be fair if you give Vundle full credit it deserves instead just calling "inspired by"… As for contribution back i meant 'shellslash' issue which i think still present in Vundle but your fork lists it as an advantage over Vundle "Works if you set 'shellslash' in your .vimrc." Closing. |
@gmarik Thank you for the responce. I will improve the documentation later.
I cant send patch for it. It is accepted? |
@Shougo the patch will be accepted once tested…etc, regular stuff. |
Thank you! |
http://gmarik.info/blog/2014/02/04/why-i-stopped-contributing-to-vundle
In first, I must apologize to @gmarik.
I will delete similiar code from Vundle later.
But neobundle must keep compatiblities...(It is not easy)
The text was updated successfully, but these errors were encountered: