Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: why I stopped contributing to vundle #378

Closed
Shougo opened this issue Feb 5, 2014 · 12 comments
Closed

Re: why I stopped contributing to vundle #378

Shougo opened this issue Feb 5, 2014 · 12 comments

Comments

@Shougo
Copy link
Contributor

Shougo commented Feb 5, 2014

http://gmarik.info/blog/2014/02/04/why-i-stopped-contributing-to-vundle

In first, I must apologize to @gmarik.

Author claims that it was just "inspired" when in fact if you look at Vundle's code and compare with "inspired" code you can see it's a copy including comments with some renames and additions.
It's OSS and "shit happens" but I think keeping it as a fork and contributing back would be much more rewarding for all of us.

I will delete similiar code from Vundle later.
But neobundle must keep compatiblities...(It is not easy)

@Shougo
Copy link
Contributor Author

Shougo commented Feb 5, 2014

In past, I forked your plugin and use it. Yes.
I added features(vimproc support, shellslash support, ....)
But it is too far from original. And I think it is not accepted in upstream(Example: Renaming commands).
So, I created neobundle and full scratched.

https://github.com/Shougo/neobundle.vim

If neobundle stops Vundle development, I must apologize. It may be wrong way.

@Shougo
Copy link
Contributor Author

Shougo commented Feb 5, 2014

In first version, "it is based on Vundle", Yes(it is documented).
But in later version, it is none of Vundle code(I rewrited it).
Because, I think neobundle has been another plugin compared Vundle.
So, I deleted "based on Vundle".

I can add "based on Vundle in first version" in the documentation if it is better.
And I can change license as Vundle compatible.

@Shougo
Copy link
Contributor Author

Shougo commented Feb 5, 2014

I will delete similiar code from Vundle later.
But neobundle must keep compatiblities...(It is not easy)

Can you tel me the problem code in latest neobundle?
I will remove it.

If the problem is documentation or license, I will fix it.
But I'm not good for English writer. So pull request is better.

@Shougo
Copy link
Contributor Author

Shougo commented Feb 5, 2014

I added the copyright and fix the "inspired".

@Shougo
Copy link
Contributor Author

Shougo commented Feb 5, 2014

I didn't not undestand OSS's license, so I have mistaked.
I don't want to battle with Vundle.
I want to fix the license issue. Can you check it?

@Shougo
Copy link
Contributor Author

Shougo commented Feb 5, 2014

https://github.com/gmarik/vundle/pulls

Vundle has many pull request for features.
Yes, I can send pull requests, but I think it is not merged(because, it is big feature).

It's been serving my needs well as I wanted it to be very simple and easy to use, with no extra features and no extra complexity.

@gmarik does not want to add extra features I think.

@steveno
Copy link

steveno commented Feb 5, 2014

@Shougo so, what exactly did you do? Copy the repo, pull in all the pull requests on top of it, and write your name all over it?

@Shougo
Copy link
Contributor Author

Shougo commented Feb 6, 2014

Sorry, I have not much time to explain it now. And I'm not good English writer.

It is two points in this problems.

  • License/OSS problem

It is my fault. I did not understand this problem until yesterday. Sorry, It must be fixed. I want to fix problems.

  • I do not contribute to upstream problem

Vundle has many pull request for features.
Yes, I can send pull requests, but I think it is not merged(because, it is big feature).

I can contribute it. But I think it is not acceptable. It is really big features(see neobundle code).
It may break compatibilities.

@gmarik
Copy link
Contributor

gmarik commented Feb 6, 2014

@Shougo thanks for quick response…

IMO it'll be fair if you give Vundle full credit it deserves instead just calling "inspired by"…
Which you did already therefore I consider this issue no more.

As for contribution back i meant 'shellslash' issue which i think still present in Vundle but your fork lists it as an advantage over Vundle "Works if you set 'shellslash' in your .vimrc."

Closing.

@Shougo
Copy link
Contributor Author

Shougo commented Feb 6, 2014

@gmarik Thank you for the responce. I will improve the documentation later.
And I want to contribute Vundle and join Vundle team.

As for contribution back i meant 'shellslash' issue which i think still present in Vundle but your fork lists it as an advantage over Vundle "Works if you set 'shellslash' in your .vimrc."

I cant send patch for it. It is accepted?

@gmarik
Copy link
Contributor

gmarik commented Feb 8, 2014

@Shougo the patch will be accepted once tested…etc, regular stuff.
Thanks!

@Shougo
Copy link
Contributor Author

Shougo commented Feb 10, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants