Bump androidx-lifecycle from 2.8.1 to 2.8.2 #291
build.yaml
on: pull_request
Build
5m 12s
Validate Workflows
6s
Annotations
9 warnings and 1 notice
Build
Processed 19 files: 15 tests ✅ passed, checks: ⚠️ 8 warnings
|
Correctness: Use FragmentContainerView instead of the <fragment> tag:
demo-project/app/src/main/res/layout/content_main.xml#L8
Replace the <fragment> tag with FragmentContainerView.
FragmentContainerView replaces the <fragment> tag as the preferred way of adding fragments via XML. Unlike the <fragment> tag, FragmentContainerView uses a normal `FragmentTransaction` under the hood to add the initial fragment, allowing further FragmentTransaction operations on the FragmentContainerView and providing a consistent timing for lifecycle events.
<fragment
~~~~~~~~
|
Performance: Unused resources:
demo-project/app/src/main/res/values/dimens.xml#L3
The resource `R.dimen.activity_horizontal_margin` appears to be unused
Unused resources make applications larger and slow down builds.
The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead.
You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests =true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests =true.
,
<dimen name="activity_horizontal_margin">16dp</dimen>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Performance: Unused resources:
demo-project/app/src/main/res/values/dimens.xml#L4
The resource `R.dimen.activity_vertical_margin` appears to be unused
Unused resources make applications larger and slow down builds.
The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead.
You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests =true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests =true.
,
<dimen name="activity_vertical_margin">16dp</dimen>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Performance: Unused resources:
demo-project/app/src/main/res/values/strings.xml#L11
The resource `R.string.hello_second_fragment` appears to be unused
Unused resources make applications larger and slow down builds.
The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead.
You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests =true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests =true.
,
<string name="hello_second_fragment">Hello second fragment. Arg: %1$s</string>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Usability:Icons: Monochrome icon is not defined:
demo-project/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml#L2
The application adaptive icon is missing a monochrome tag
If `android:roundIcon` and `android:icon` are both in your manifest, you must either remove the reference to `android:roundIcon` if it is not needed; or, supply the monochrome icon in the drawable defined by the `android:roundIcon` and `android:icon` attribute.
For example, if `android:roundIcon` and `android:icon` are both in the manifest, a launcher might choose to use `android:roundIcon` over `android:icon` to display the adaptive app icon. Therefore, your themed application iconwill not show if your monochrome attribute is not also specified in `android:roundIcon`.
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
^
|
Usability:Icons: Monochrome icon is not defined:
demo-project/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml#L2
The application adaptive roundIcon is missing a monochrome tag
If `android:roundIcon` and `android:icon` are both in your manifest, you must either remove the reference to `android:roundIcon` if it is not needed; or, supply the monochrome icon in the drawable defined by the `android:roundIcon` and `android:icon` attribute.
For example, if `android:roundIcon` and `android:icon` are both in the manifest, a launcher might choose to use `android:roundIcon` over `android:icon` to display the adaptive app icon. Therefore, your themed application iconwill not show if your monochrome attribute is not also specified in `android:roundIcon`.
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
^
|
Accessibility: Image without `contentDescription`:
demo-project/app/src/main/res/layout/activity_main.xml#L25
Missing `contentDescription` attribute on image
Non-textual widgets like ImageViews and ImageButtons should use the `contentDescription` attribute to specify a textual description of the widget such that screen readers and other accessibility tools can adequately describe the user interface.
Note that elements in application screens that are purely decorative and do not provide any content or enable a user action should not have accessibility content descriptions. In this case, set their descriptions to `@null`. If your app's minSdkVersion is 16 or higher, you can instead set these graphical elements' `android:importantForAccessibility` attributes to `no`.
Note that for text fields, you should not set both the `hint` and the `contentDescription` attributes since the hint will never be shown. Just set the `hint`.
<com.google.android.material.floatingactionbutton.FloatingActionButton
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Internationalization:Bidirectional Text: Using RTL attributes without enabling RTL support:
demo-project/login/src/main/AndroidManifest.xml#L1
The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest
To enable right-to-left support, when running on API 17 and higher, you must set the `android:supportsRtl` attribute in the manifest `<application>` element.
If you have started adding RTL attributes, but have not yet finished the migration, you can set the attribute to false to satisfy this lint check.
|
Build
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|