Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added position to BuildConfigField to keep the insertion order #58

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

gmazzo
Copy link
Owner

@gmazzo gmazzo commented Jun 20, 2023

Fixes #52 allowing to keep the insertion order, by introducing a position field to BuildConfigField which defaults to the collection size.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #58 (73ffe6d) into main (7cb7079) will increase coverage by 0.07%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main      #58      +/-   ##
============================================
+ Coverage     80.34%   80.42%   +0.07%     
- Complexity       53       55       +2     
============================================
  Files            15       15              
  Lines           229      235       +6     
  Branches         18       19       +1     
============================================
+ Hits            184      189       +5     
  Misses           32       32              
- Partials         13       14       +1     
Impacted Files Coverage Δ
...om/github/gmazzo/gradle/plugins/BuildConfigTask.kt 78.26% <80.00%> (-1.74%) ⬇️
...le/plugins/internal/DefaultBuildConfigClassSpec.kt 92.30% <100.00%> (+2.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gmazzo gmazzo merged commit 5e7b712 into main Jun 21, 2023
5 checks passed
@gmazzo gmazzo deleted the keep-order branch June 21, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any reason not to use a LinkedHashMap as before?
1 participant