Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added position to BuildConfigField to keep the insertion order #58

Merged
merged 1 commit into from
Jun 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ dependencies {
implementation(libs.apache.commons.lang)

testImplementation(gradleTestKit())
testImplementation(gradleKotlinDsl())
testImplementation(libs.kotlin.test)
testImplementation(libs.mockk)
testImplementation("org.junit.jupiter:junit-jupiter-params")
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,7 @@ interface BuildConfigField : Named {
@get:Input
val optional: Property<Boolean>

@get:Input
val position: Property<Int>

}
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ abstract class BuildConfigTask : DefaultTask() {
abstract val outputDir: DirectoryProperty

@TaskAction
protected fun generateBuildConfigFile() = outputDir.get().asFile.let { dir ->
fun generateBuildConfigFile() = outputDir.get().asFile.let { dir ->
dir.deleteRecursively()
dir.mkdirs()

Expand All @@ -45,7 +45,12 @@ abstract class BuildConfigTask : DefaultTask() {
BuildConfigGeneratorSpec(
className = className,
packageName = packageName,
fields = it.buildConfigFields,
fields = it.buildConfigFields.sortedWith { a, b ->
when (val cmp = a.position.get().compareTo(b.position.get())) {
0 -> a.name.compareTo(b.name)
else -> cmp
}
},
outputDir = dir
)
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ internal abstract class DefaultBuildConfigClassSpec @Inject constructor(
type: String,
name: String,
action: (BuildConfigField) -> Unit,
) : NamedDomainObjectProvider<BuildConfigField> =
): NamedDomainObjectProvider<BuildConfigField> = buildConfigFields.size.let { position ->
buildConfigFields.register(name) {
it.type.value(type.removeSuffix("?")).disallowChanges()
it.optional.value(type.endsWith("?")).disallowChanges()
it.position.convention(position)
action(it)
}
}

override fun buildConfigField(type: String, name: String, value: String) =
buildConfigField(type, name) { it.value.value(value).disallowChanges() }
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package com.github.gmazzo.gradle.plugins

import com.github.gmazzo.gradle.plugins.generators.BuildConfigGenerator
import com.github.gmazzo.gradle.plugins.generators.BuildConfigGeneratorSpec
import com.github.gmazzo.gradle.plugins.internal.DefaultBuildConfigClassSpec
import io.mockk.mockk
import io.mockk.verify
import org.gradle.kotlin.dsl.create
import org.gradle.kotlin.dsl.newInstance
import org.gradle.testfixtures.ProjectBuilder
import org.junit.jupiter.api.Test

class BuildConfigTaskTest {

private val project = ProjectBuilder.builder().build()

private val spec: BuildConfigClassSpec = project.objects.newInstance<DefaultBuildConfigClassSpec>("spec").apply {
className.set("aClassName")
packageName.set("aPackage")
}

private val outDir = project.layout.buildDirectory.dir("outDir")

private val generator: BuildConfigGenerator = mockk(relaxUnitFun = true)

private val task = project.tasks.create<BuildConfigTask>("testedTask") {
generator.set(this@BuildConfigTaskTest.generator)
outputDir.set(outDir)
specs.add(spec)
}

@Test
fun `order of fields must be honored when propagated to the generator`() {
val fields = sequenceOf(
spec.buildConfigField("Int", "FIRST", "1"),
spec.buildConfigField("Int", "SECOND", "2"),
spec.buildConfigField("Int", "THIRD", "3"),
spec.buildConfigField("Int", "LAST", "9"),
).map { it.get() }.toList()

task.generateBuildConfigFile()

verify {
generator.execute(
BuildConfigGeneratorSpec(
className = "aClassName",
packageName = "aPackage",
fields = fields,
outputDir = outDir.get().asFile.absoluteFile,
)
)
}
}

}