Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser File support? #21

Closed
jrobinso opened this issue Jan 17, 2019 · 3 comments
Closed

Browser File support? #21

jrobinso opened this issue Jan 17, 2019 · 3 comments

Comments

@jrobinso
Copy link
Contributor

Thoughts on supporting the browser File object? If you're not working on it, I might take a crack at it. It should be pretty simple, I think we need to implement an "io" file class for it, then some conditional logic to prevent the app from blowing up if run in node.

@rbuels
Copy link
Contributor

rbuels commented Jan 17, 2019 via email

@jrobinso
Copy link
Contributor Author

@rbuels That was my plan, but @cmdcolin pointed to using the fileHandle option and supplying an implementation from outside. That might make more sense, and leaving cram-js a pure node application.

@jrobinso
Copy link
Contributor Author

@rbuels @cmdcolin Perhaps we could put an implementation of filehandle (for args.filehandel) for the browser File object as an example file somewhere for other people to copy and use. This keeps cram-js pure node. When I have one I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants