Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron app needs polish #1045

Closed
rbuels opened this issue May 2, 2018 · 1 comment
Closed

electron app needs polish #1045

rbuels opened this issue May 2, 2018 · 1 comment
Assignees
Labels
bug this is a problem that needs to be fixed
Milestone

Comments

@rbuels
Copy link
Collaborator

rbuels commented May 2, 2018

image

  • need to suppress error messages at the bottom of the welcome screen
  • session delete buttons missing
  • "Previous sessions" needs styling
  • change "Previous sessions" to "Saved sessions"
  • don't mention that this is desktop mode, they know it's a desktop app
  • make user session names more human readable, not long paths
  • fix alignment and styling of "open *" buttons
  • need to have a mechanism to delete unused sessions after a certain amount of time, so that heavy users don't have old sessions piling up

some of these might be regressions

@rbuels rbuels added the bug this is a problem that needs to be fixed label May 2, 2018
@rbuels rbuels added this to the 1.15.0 milestone May 2, 2018
@cmdcolin
Copy link
Contributor

cmdcolin commented May 8, 2018

Agree with all these items :) I guess the error message thing is since the welcome page is sort of a modification of the error page. I could either suppress the error if it's just the 404 on that data dir, or I could try and redesign the welcome so it's a different setup. Not sure which is better.

The only regression is that the session delete button is missing probably just due to css

@rbuels rbuels modified the milestones: 1.15.0, 1.14.2 Jun 4, 2018
@rbuels rbuels closed this as completed in e5aee18 Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug this is a problem that needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants