Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup for a GFF3Tabix feature: multiple attribute values are rendered as a single value #1122

Closed
loraine-gueguen opened this issue Jul 16, 2018 · 3 comments
Milestone

Comments

@loraine-gueguen
Copy link
Contributor

loraine-gueguen commented Jul 16, 2018

Unlike with NCList StoreClass, the popup with GFF3Tabix storeClass is wrong when one attribute has multiple values: they are joined with a comma and rendered as a single one. This induces trouble to distinguish the different values (Which are the "value-separator commas" or the "inside-value commas"?) and this prevent to apply callbacks on each individual value (these callbacks are working well with the NCList StoreClass).

Here part of the popup with a NCList StoreClass (created using flatfile-to-json.pl):

with_nclist

Here the same data with the GFF3Tabix (and same track configuration except for storeClass, urlTemplate and tbiUrlTemplate):

with_gff3tabix

@loraine-gueguen loraine-gueguen changed the title popup for a GFF3tabix feature: multiple attribute values are rendered as a single value popup for a GFF3Tabix feature: multiple attribute values are rendered as a single value Jul 16, 2018
@cmdcolin
Copy link
Contributor

@rbuels any idea about this?

The gff-js code has something related to splitting on comma but I dunno exactly how that passes through https://github.com/GMOD/gff-js/blob/master/src/util.js#L91

@rbuels
Copy link
Collaborator

rbuels commented Jul 16, 2018 via email

@cmdcolin
Copy link
Contributor

Should be fixed now! Thanks for the report @loraine-gueguen !!! Will include in release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants