New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a static variable to check against adding the y-scale bar #1218

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Sep 30, 2018

This is a PR to address #1214 where the Y scale bar would be displayed over features. I think it is because the fillHistograms was async so it would be determined at some point to back out of showing histograms but the async would complete and show it (due to issues like #1190)

This PR makes it explicit to not add the y-scale if it hits the async fillHistograms code after determining to not show them

@rbuels rbuels added this to the 1.15.4 milestone Oct 2, 2018

@rbuels rbuels merged commit e54dba7 into dev Oct 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Oct 2, 2018

@cmdcolin cmdcolin deleted the 1214_yscale_bar branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment