Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver not working with kernel 4.19 lts #154

Open
SolZer opened this issue Oct 26, 2018 · 21 comments

Comments

Projects
None yet
10 participants
@SolZer
Copy link

commented Oct 26, 2018

upgraded from 4.18 to 4.19, and wifi adapter is no longer recognized

@ekeyser

This comment has been minimized.

Copy link

commented Oct 26, 2018

Hi Solzer, did you recompile the driver? When kernel upgrades occur the driver modules are not copied over to the new kernel. Usually a make; sudo make install (and then reboot or insmod) should correct this. Just checking.

@kimocoder

This comment has been minimized.

Copy link

commented Oct 26, 2018

Kernel v4.19 will need a patch to her supported. Take a look in "gordboy" repo

@jasontm7

This comment has been minimized.

Copy link

commented Nov 21, 2018

Hi ekeyser,
I know this thread is getting a little old but I had the same issue when Fedora upgraded to 4.19 kernel. My particular issue was a duplicate #define error in ./include/wifi.h: Line 980: #define IEEE80211_MAX_AMPDU_BUF 0x40 which was also defined elsewhere as #define IEEE80211_MAX_AMPDU_BUF 0x100.
So I commented out this #define in wifi.h and let it compile: /#define IEEE80211_MAX_AMPDU_BUF 0x40/
This worked for me. Can't guarantee it'll work for everyone but it's something to try if nothing else works and it's easy. I know there's probably a reason to make this particular buffer smaller but it maxes out my internet speed and works after reboots so I don't care :-)

@romulasry

This comment has been minimized.

Copy link

commented Dec 5, 2018

If only someone would upstream the patches from: https://github.com/gordboy/rtl8812au

@fffaraz

This comment has been minimized.

Copy link

commented Dec 21, 2018

I guess I have the same problem.

 CC [M]  /home/faraz/rtl8812au-master/os_dep/linux/os_intfs.o
/home/faraz/rtl8812au-master/os_dep/linux/os_intfs.c:1069:22: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .ndo_select_queue = rtw_select_queue,
                      ^~~~~~~~~~~~~~~~
/home/faraz/rtl8812au-master/os_dep/linux/os_intfs.c:1069:22: note: (near initialization for ‘rtw_netdev_ops.ndo_select_queue’)
cc1: some warnings being treated as errors
scripts/Makefile.build:303: recipe for target '/home/faraz/rtl8812au-master/os_dep/linux/os_intfs.o' failed
make[2]: *** [/home/faraz/rtl8812au-master/os_dep/linux/os_intfs.o] Error 1
Makefile:1517: recipe for target '_module_/home/faraz/rtl8812au-master' failed
make[1]: *** [_module_/home/faraz/rtl8812au-master] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.19.10-041910-generic'
Makefile:1064: recipe for target 'modules' failed
make: *** [modules] Error 2
gcc --version
gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
uname -r -v -m
4.19.10-041910-generic #201812170433 SMP Mon Dec 17 09:35:34 UTC 2018 x86_64
@chovy

This comment has been minimized.

Copy link

commented Jan 6, 2019

I'm having same problem with 4.20

$ make
make ARCH=x86_64 CROSS_COMPILE= -C /lib/modules/4.20.0-042000-generic/build M=/home/ettinger/tmp/rtl8812au  modules
make[1]: Entering directory '/usr/src/linux-headers-4.20.0-042000-generic'
  CC [M]  /home/ettinger/tmp/rtl8812au/os_dep/linux/os_intfs.o
/home/ettinger/tmp/rtl8812au/os_dep/linux/os_intfs.c:1069:22: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .ndo_select_queue = rtw_select_queue,
                      ^~~~~~~~~~~~~~~~
/home/ettinger/tmp/rtl8812au/os_dep/linux/os_intfs.c:1069:22: note: (near initialization for ‘rtw_netdev_ops.ndo_select_queue’)
cc1: some warnings being treated as errors
scripts/Makefile.build:291: recipe for target '/home/ettinger/tmp/rtl8812au/os_dep/linux/os_intfs.o' failed
make[2]: *** [/home/ettinger/tmp/rtl8812au/os_dep/linux/os_intfs.o] Error 1
Makefile:1563: recipe for target '_module_/home/ettinger/tmp/rtl8812au' failed
make[1]: *** [_module_/home/ettinger/tmp/rtl8812au] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.20.0-042000-generic'
Makefile:1064: recipe for target 'modules' failed
make: *** [modules] Error 2
@mirix

This comment has been minimized.

Copy link

commented Jan 8, 2019

Compare Makefile and os_dep/linux/os_intfs.c between gnab and gordboy versions.

In the Makefile there are a few extra flags that differ. My guess is that this is irrelevant but I changed them anyway so that both files match.

In os_dep/linux/os_intfs.c search for rtw_select_queue. There are three occurrences. The last two are identical at the time of this writing. The first is within a series of if statements. The gordboy version has an extra one for kernel 4.19.

Replace the gnab chunk with the gordboy version and you are done: it compiles and works.

Tested with liquorix 4.19 on Bodhi 5 (Ubuntu 18.04).

@mishaturnbull

This comment has been minimized.

Copy link

commented Jan 24, 2019

Same problem now --

Kali Linux, uname -a -> Linux [redacted] 4.19.0-kali1-amd64 #1 SMP Debian 4.19.13-1kali1 (2019-01-03) x86_64 GNU/Linux

Exact same error as @chovy when trying to make the driver. It may be worth noting that the guide I followed suggested an apt install linux-headers-generic before even cloning this repo, and on Kali, I cannot find that package.

@chovy

This comment has been minimized.

Copy link

commented Jan 24, 2019

@mirix

This comment has been minimized.

Copy link

commented Jan 24, 2019

Yesterday I did a system upgrade and Liquorix 4.20 was installed. The module was build automatically via DKMS. This means that the simple hack described above works for versions 4.19 and 4.20.

@chovy

This comment has been minimized.

Copy link

commented Jan 24, 2019

@mishaturnbull

This comment has been minimized.

Copy link

commented Jan 24, 2019

I've had no luck installing via DKMS or the gordboy repo, but what I was able to do was use the CD drive that came with the dongle to install the Bluetooth driver, and the WiFi driver via https://github.com/lwfinger/8723bu. If anyone's interested I can post the code from the CD drive.

@chovy

This comment has been minimized.

Copy link

commented Jan 24, 2019

I'm sorry I misled you. I thought this was about sound drivers for my laptop, not the wifi card. I don't know how to get it to work.

@mirix

This comment has been minimized.

Copy link

commented Jan 24, 2019

Misha, the gordboy code doesn't work for me either. What works is hacking a couple of files from this repo as explained above.

@mirix

This comment has been minimized.

Copy link

commented Feb 1, 2019

No need to touch the Makefile. Just replace os_dep/linux/os_intfs.c with the attached file (change extension from .txt to .c) and your are good to go.

os_intfs.txt

@mirix

This comment has been minimized.

Copy link

commented Feb 5, 2019

Hi guys, the aircrack-ng/rtl8812au drivers work for me. I have tested driver v5.3.4 against kernel 4.19.19. It works out of the box (DKMS method), the repo seems to be actively maintained, it wraps all the commands in convenient install/uninstall scripts, it is supposed to work with kernels 4.20 and 5.0, and it contains more recent versions of the drivers (not the most recent, though).

@chovy

This comment has been minimized.

Copy link

commented Feb 5, 2019

@mirix where can i read more about this?

@mirix

This comment has been minimized.

@AstroDrabb

This comment has been minimized.

Copy link

commented Mar 24, 2019

upgraded from 4.18 to 4.19, and wifi adapter is no longer recognized

I have made a fix so it works with 4.19.* and also 5.0.* here:
https://github.com/AstroDrabb/rtl8812au

@chovy

This comment has been minimized.

Copy link

commented Mar 24, 2019

@AstroDrabb

This comment has been minimized.

Copy link

commented Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.