Do not clear the selection on mouse up single click. This changes the…

… behavior when clicking in a non-key window that has a selection: now the selection won't be removed. That's good because that's how macOS seems to work (at least 10.14, which is all I tested). Furthermore, it fixes issue 7871 where the OS reported click=0 for no good reason. The selection has always been removed in mouseDownImpl in .
gnachman · Aug 25, 2019 · 2faba4c · 2faba4c
1 parent 09a74a2
commit 2faba4c
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/sources/PTYTextView.m b/sources/PTYTextView.m
@@ -1979,9 +1979,6 @@ - (void)mouseUp:(NSEvent *)event {
             }
         }
 
-        if (!_selection.appending) {
-            [_selection clearSelection];
-        }
         if (willFollowLink) {
             [_urlActionHelper openTargetWithEvent:event inBackground:altPressed];
         } else {