Rename constant KEY_DEFAULT_BG_ALPHA_ONLY

to `KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR`. As per request: #277 (comment)
gnachman · Apr 22, 2016 · 38c38f7 · 38c38f7
1 parent b376375
commit 38c38f7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/sources/ITAddressBookMgr.h b/sources/ITAddressBookMgr.h
@@ -139,7 +139,7 @@
 // Terminal
 #define KEY_DISABLE_WINDOW_RESIZING           @"Disable Window Resizing"
 #define KEY_PREVENT_TAB                       @"Prevent Opening in a Tab"
-#define KEY_DEFAULT_BG_ALPHA_ONLY             @"Only The Default BG Color Uses Transparency"
+#define KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR @"Only The Default BG Color Uses Transparency"
 #define KEY_OPEN_TOOLBELT                     @"Open Toolbelt"
 #define KEY_HIDE_AFTER_OPENING                @"Hide After Opening"
 #define KEY_SYNC_TITLE                        @"Sync Title"

diff --git a/sources/PTYSession.m b/sources/PTYSession.m
@@ -1033,7 +1033,7 @@ - (BOOL)setScreenSize:(NSRect)aRect parent:(id<WindowControllerInterface>)parent
     const float theBlend =
         [_profile objectForKey:KEY_BLEND] ? [[_profile objectForKey:KEY_BLEND] floatValue] : 0.5;
     [self setBlend:theBlend];
-    [self setTransparencyAffectsOnlyDefaultBackgroundColor:[[_profile objectForKey:KEY_DEFAULT_BG_ALPHA_ONLY] boolValue]];
+    [self setTransparencyAffectsOnlyDefaultBackgroundColor:[[_profile objectForKey:KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR] boolValue]];
 
     [_wrapper addSubview:_textview];
     [_textview setFrame:NSMakeRect(0, VMARGIN, aSize.width, aSize.height - VMARGIN)];
@@ -2647,7 +2647,7 @@ - (void)setPreferencesFromAddressBookEntry:(NSDictionary *)aePrefs
     // transparency
     [self setTransparency:[iTermProfilePreferences floatForKey:KEY_TRANSPARENCY inProfile:aDict]];
     [self setBlend:[iTermProfilePreferences floatForKey:KEY_BLEND inProfile:aDict]];
-    [self setTransparencyAffectsOnlyDefaultBackgroundColor:[iTermProfilePreferences floatForKey:KEY_DEFAULT_BG_ALPHA_ONLY inProfile:aDict]];
+    [self setTransparencyAffectsOnlyDefaultBackgroundColor:[iTermProfilePreferences floatForKey:KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR inProfile:aDict]];
 
     // bold 
     [self setUseBoldFont:[iTermProfilePreferences boolForKey:KEY_USE_BOLD_FONT

diff --git a/sources/ProfilesWindowPreferencesViewController.m b/sources/ProfilesWindowPreferencesViewController.m
@@ -121,7 +121,7 @@ - (void)awakeFromNib {
                    type:kPreferenceInfoTypeCheckbox];
 
    info = [self defineControl:_transparencyAffectsOnlyDefaultBackgroundColor
-                          key:KEY_DEFAULT_BG_ALPHA_ONLY
+                          key:KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR
                          type:kPreferenceInfoTypeCheckbox];
    info.observer = ^() { _transparencyAffectsOnlyDefaultBackgroundColor.enabled = (_transparency.doubleValue > 0); };
 

diff --git a/sources/iTermProfilePreferences.m b/sources/iTermProfilePreferences.m
@@ -203,7 +203,7 @@ + (NSDictionary *)defaultValueMap {
                   KEY_SYNC_TITLE: @NO,
                   KEY_DISABLE_WINDOW_RESIZING: @NO,
                   KEY_PREVENT_TAB: @NO,
-                  KEY_DEFAULT_BG_ALPHA_ONLY: @NO,
+                  KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR: @NO,
                   KEY_OPEN_TOOLBELT: @NO,
                   KEY_ASCII_ANTI_ALIASED: @NO,
                   KEY_NONASCII_ANTI_ALIASED: @NO,