-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Toggle: Only apply transparency to default bg #277
Feature - Toggle: Only apply transparency to default bg #277
Commits on Apr 21, 2016
-
Apply Alpha only to default BG color - Core Functionality
A conditional check for non default BG colors will prevent alpha being applied to them. `_defaultBGAlphaOnly` will reference a user setting(checkbox) to make this feature opt-in.
Brennan committedApr 21, 2016 Configuration menu - View commit details
-
Copy full SHA for 27e881a - Browse repository at this point
Copy the full SHA 27e881aView commit details -
Resize Preference Panel Height
Height is adjusted for the `77f-eM-Dma`/`Prefs - Profiles - Window` to make room for new checkbox element. Doing so adjusted all the `y` position values.
Brennan committedApr 21, 2016 Configuration menu - View commit details
-
Copy full SHA for fa4f566 - Browse repository at this point
Copy the full SHA fa4f566View commit details -
Add checkbox UI element to Profiles-Window tab
I added the checkbox with copy/paste of the previous element within the XCode UI editor and updated the properties. I could not find how to add the `outlet` hunk via that interface so directly added it by editing the XML. The id I used for the `outlet` node doesn't have any conflicts and is presumably safe.
Brennan committedApr 21, 2016 Configuration menu - View commit details
-
Copy full SHA for 19e503c - Browse repository at this point
Copy the full SHA 19e503cView commit details -
UI-Profiles-Window Tab - Update
nextKeyView
navigation connectionsPoints the `_preventTab` node to `_defaultBGAlphaOnly` node. Also added a `nextKeyView` connection from `syncTitle` to `_preventTab` as it was missing one.
Brennan committedApr 21, 2016 Configuration menu - View commit details
-
Copy full SHA for 70f342b - Browse repository at this point
Copy the full SHA 70f342bView commit details -
Connect UI setting to
_defaultBGAlphaOnly
variableThis finishes the feature off by connecting the UI checkbox setting to the first commit that introduced the `_defaultBGAlphaOnly` variable. I've tried to keep the location of additions consistent, either being inserted after `blend` or `_preventDefault` logic.
Brennan committedApr 21, 2016 Configuration menu - View commit details
-
Copy full SHA for a4b7395 - Browse repository at this point
Copy the full SHA a4b7395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26fda26 - Browse repository at this point
Copy the full SHA 26fda26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f68a10 - Browse repository at this point
Copy the full SHA 4f68a10View commit details -
Rename variable
defaultBGAlphaOnly
to `setTransparencyAffectsOnlyDefaultBackgroundColor`. As per request: gnachman#277 (comment)
Brennan committedApr 21, 2016 Configuration menu - View commit details
-
Copy full SHA for 48b8911 - Browse repository at this point
Copy the full SHA 48b8911View commit details -
Disable setting when transparency is off
As per request: gnachman#277 (comment)
Brennan committedApr 21, 2016 Configuration menu - View commit details
-
Copy full SHA for ebfa170 - Browse repository at this point
Copy the full SHA ebfa170View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad4ffa1 - Browse repository at this point
Copy the full SHA ad4ffa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b376375 - Browse repository at this point
Copy the full SHA b376375View commit details
Commits on Apr 22, 2016
-
Rename constant
KEY_DEFAULT_BG_ALPHA_ONLY
to `KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR`. As per request: gnachman#277 (comment)
Brennan committedApr 22, 2016 Configuration menu - View commit details
-
Copy full SHA for 38c38f7 - Browse repository at this point
Copy the full SHA 38c38f7View commit details