Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Toggle: Only apply transparency to default bg #277

Commits on Apr 21, 2016

  1. Apply Alpha only to default BG color - Core Functionality

    A conditional check for non default BG colors will prevent alpha being applied to them. `_defaultBGAlphaOnly` will reference a user setting(checkbox) to make this feature opt-in.
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    27e881a View commit details
    Browse the repository at this point in the history
  2. Resize Preference Panel Height

    Height is adjusted for the `77f-eM-Dma`/`Prefs - Profiles - Window` to make room for new checkbox element. Doing so adjusted all the `y` position values.
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    fa4f566 View commit details
    Browse the repository at this point in the history
  3. Add checkbox UI element to Profiles-Window tab

    I added the checkbox with copy/paste of the previous element within the XCode UI editor and updated the properties. 
    
    I could not find how to add the `outlet` hunk via that interface so directly added it by editing the XML. The id I used for the `outlet` node doesn't have any conflicts and is presumably safe.
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    19e503c View commit details
    Browse the repository at this point in the history
  4. UI-Profiles-Window Tab - Update nextKeyView navigation connections

    Points the `_preventTab` node to `_defaultBGAlphaOnly` node. 
    
    Also added a `nextKeyView` connection from `syncTitle` to `_preventTab` as it was missing one.
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    70f342b View commit details
    Browse the repository at this point in the history
  5. Connect UI setting to _defaultBGAlphaOnly variable

    This finishes the feature off by connecting the UI checkbox setting to the first commit that introduced the `_defaultBGAlphaOnly` variable.
    
    I've tried to keep the location of additions consistent, either being inserted after `blend` or `_preventDefault` logic.
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    a4b7395 View commit details
    Browse the repository at this point in the history
  6. Update copy

    As per request: gnachman#277 (comment)
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    26fda26 View commit details
    Browse the repository at this point in the history
  7. Change "Main" to "Default"

    As per request: gnachman#277 (comment)
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    4f68a10 View commit details
    Browse the repository at this point in the history
  8. Rename variable defaultBGAlphaOnly

    to `setTransparencyAffectsOnlyDefaultBackgroundColor`.
    
    As per request: gnachman#277 (comment)
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    48b8911 View commit details
    Browse the repository at this point in the history
  9. Disable setting when transparency is off

    As per request: gnachman#277 (comment)
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    ebfa170 View commit details
    Browse the repository at this point in the history
  10. Fix typo: colour to color

    Use American English spelling.
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    ad4ffa1 View commit details
    Browse the repository at this point in the history
  11. Change main to default

    As per request: gnachman#277 (comment)
    Brennan committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    b376375 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2016

  1. Rename constant KEY_DEFAULT_BG_ALPHA_ONLY

    to `KEY_TRANSPARENCY_AFFECTS_ONLY_DEFAULT_BACKGROUND_COLOR`.
    
    As per request: gnachman#277 (comment)
    Brennan committed Apr 22, 2016
    Configuration menu
    Copy the full SHA
    38c38f7 View commit details
    Browse the repository at this point in the history