Adding a new color preference setting that defines a custom color for underlining. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underlining text. If this is enabled, underlining will always use the set color, independent of the color that the character itself is displayed with.
| @@ -2635,14 +2635,19 @@ - (void)setPreferencesFromAddressBookEntry:(NSDictionary *)aePrefs | |||
| _tmuxTitleOutOfSync = YES; | |||
| } | |||
|
|
|||
| BOOL use_underline = [iTermProfilePreferences boolForKey:KEY_USE_UNDERLINE_COLOR inProfile:aDict]; | |||
There was a problem hiding this comment.
Minor nitpick: useUnderline instead of use_underline.
|
Good work! Very close to submittable; I just wrote a few small comments. I'll take care of adding the golden image for Travis. |
|
Updated with your feedback, except for the change to result, see above. |
|
Merged. Thank you! |
|
Thanks for merging and the feedback, and more generally for all your great work on iTerm2! |
|
Hi, is there anyway I can change iTerm2 Colorspace from sRGB to P3 or to my current display's colorspace? |
|
@josepheiba The beta uses p3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of the v3.1 branch. I believe I have followed most of the instructions in #286, except for two things:
[self.colorMap colorForKey:kColorMapUnderline]to account for the fact that we now expect it to return nil in this case. It would normally have returned a hardcoded red. Not so nice, maybe I'm missing something?Please have a look. Feel free to send back to me if there's more to do.