Add "Raw coprocess command" to semantic history. #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the possibility to run a script / program as a deferred script. This is necessary to have any interaction back with iTerm. One use case is for example a small script that will write text back to iTerm to interact with the remote system while being logged in via SSH.
|
I'm absolutely unsure how to deal with the XIB file. I manually edited only the one line needed to add the menu item, but open saving the project the other modifications were added. What's the SOP here? |
|
Don't worry about the XIB file. They're horrible this way. It looks OK. |
gnachman
reviewed
Oct 1, 2016
| DLog(@"Launch coproress with script %@", script); | ||
| assert(delegate_); | ||
| [delegate_ semanticHistoryLaunchCoprocessWithCommand:script]; | ||
| return YES; | ||
| } | ||
|
|
||
| if ([prefs_[kSemanticHistoryActionKey] isEqualToString:kSemanticHistoryCommandAction]) { |
There was a problem hiding this comment.
Moving the test for fileExistsAtPath:isDirectory: below this changes the Command to run even when the file doesn't exist, which seems like an unnecessary change.
| @@ -311,6 +314,13 @@ - (BOOL)openPath:(NSString *)path | |||
| return YES; | |||
| } | |||
|
|
|||
| if ([prefs_[kSemanticHistoryActionKey] isEqualToString:kSemanticHistoryCoprocessAction]) { | |||
There was a problem hiding this comment.
Why should coprocess actions not run on directories?
| @@ -192,7 +193,8 @@ + (NSDictionary *)tagToActionMap { | |||
| @3: kSemanticHistoryEditorAction, | |||
| @4: kSemanticHistoryCommandAction, | |||
| @5: kSemanticHistoryRawCommandAction, | |||
| @6: kSemanticHistoryCoprocessAction }; | |||
| @7: kSemanticHistoryRawCoprocessAction, | |||
There was a problem hiding this comment.
Please put the new item last so the numbers are in order.
| @@ -262,6 +264,12 @@ - (IBAction)actionChanged:(id)sender | |||
| hideCaveat = NO; | |||
| hideText = NO; | |||
| break; | |||
| case 7: | |||
| [[text_ cell] setPlaceholderString:@"Enter command"]; | |||
| [caveat_ setStringValue:@"Coprocess runs when you activate Semantic History on any filename (even if it's not a avlid filename). Use \\1 for filename, \\2 for line number, \\3 for text before click, \\4 for text after click, \\5 for pwd."]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the possibility to run a script / program as a deferred script. This is necessary to have any interaction back with iTerm.One use case is for example a small script that will write text
back to iTerm to interact with the remote system while being
logged in via SSH.
This is related to: https://gitlab.com/gnachman/iterm2/issues/5197