New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent images from disappearing due to scaling #403

Merged

gnachman merged 1 commit into gnachman:master from yoichi:prevent-images-from-disappearing

Oct 3, 2019

Contributor

yoichi commented Oct 1, 2019

When I run longcat (https://github.com/mattn/longcat) on iTerm2 with option
"-H -n N" with large integer N, the image is not shown.

The debug log says:

1569935975.044434 VT100Screen.m:3950 (-[VT100Screen appendImageAtCursorWithName:width:units:height:units:preserveAspectRatio:roundUp:inset:image:data:]): Append 0 rows of image characters with 80 columns. The value of c.image is 1

There is a problem in scaling process that can make width (or height) zero.
I've confirmed the problem is fixed by 5c0ecac and the image is shown.


          Prevent images from disappearing due to scaling

5c0ecac

gnachman merged commit dd4cbeb into gnachman:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment