Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle epithets containing non #214

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

tobymarsden
Copy link

This tiny PR removes the special cases of names with epithets containing non and updates the stopword regex to match only non that's not followed by [a-zA-Z-].

It doesn't solve the Xiphipops fisheri (non Snyder, 1904) issue (i.e. that should perhaps be parsed), though, but I can open a new issue just for that if you think it's worth handling.

@dimus
Copy link
Member

dimus commented Nov 19, 2021

Thanks @tobymarsden, merging, and yes Xiphipops fisheri (non Snyder, 1904) and similar name-strings are rather common and it will be helpful to deal with them at some point. It is a bigger, more complex issue that does require a bit of investitation what exists in the wild

@dimus dimus merged commit 2a99e81 into gnames:master Nov 19, 2021
@dimus
Copy link
Member

dimus commented Nov 20, 2021

On a second thought constructs like Xiphipops fisheri (non Snyder, 1904) can easily be annotations, reference to a non-nomenclatural name usage, a ref to a chresonym).
I will talk to our taxonomists more about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants