Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a service to schedule based on an Octopus Target Rate time #47
Add a service to schedule based on an Octopus Target Rate time #47
Changes from 20 commits
6a3e948
47eb044
97383ae
108138e
ba9b362
7b50263
03ef424
5ca13eb
ff280be
85ce544
2ba1ecd
0298bf9
3554bdb
84c6f05
85747b8
7427909
5d1f03e
e3dc6db
dd6131d
e015e76
2ac1148
89fdb77
9ddbaa3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annoyingly, the HV 3.0 charger does not allow times to span midnight. If trying to set that, the API returns an error like:
"schedule.set failed: assertion failed: Session startTime (HoursMinutes(12,0)) must be < endTime (HoursMinutes(3,30))"}}
When trying to do this in the HV app, two sessions are created:
startTime -> 24:00
00:00 -> endTime
So I think there needs to be logic for this too 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to do something like this for the merging and splitting, then I put a kludge in the API client code that converts 23:59:59 into 24:00 when it's passed to the HV API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, re-thinking this. The splitting should probably happen with the hypervolt_api_client code, not in here. So then it works for anything that calls
set_schedule
.So I've changed my mind - don't split intervals spanning midnight here.