Fix Race Condition Crash Exploit #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2024
Closed
3 tasks
This was referenced Mar 13, 2024
juls0730
pushed a commit
to juls0730/fabric-carpet
that referenced
this pull request
Apr 8, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting some off-thread warnings in another mod I'm working on when spawning fake players.
This lead me to try spamming
/player foobar spawnin chat, which crashed the game.I have just changed the
thenAcceptinto athenAcceptAsyncon the main server thread. This now creates the player and spawns them on the main thread, so there are no more possible race conditions that can happen.